Skip to content

fix(nimbus): hide weekly and daily data for desktop 3dr#15738

Merged
moibra05 merged 1 commit into
mainfrom
15736
May 27, 2026
Merged

fix(nimbus): hide weekly and daily data for desktop 3dr#15738
moibra05 merged 1 commit into
mainfrom
15736

Conversation

@moibra05
Copy link
Copy Markdown
Contributor

@moibra05 moibra05 commented May 27, 2026

Because

  • The name of the desktop 3dr constant for was recently changed causing the weekly + daily data cards to incorrectly render for the desktop 3dr metric

This commit

  • Updates the weekly + daily data cards to conditionally render as long as the metric is not within an exception list currently containing the metric slugs for both mobile and desktop 3dr

Fixes #15736

@moibra05
Copy link
Copy Markdown
Contributor Author

moibra05 commented May 27, 2026

image

@moibra05 moibra05 enabled auto-merge May 27, 2026 18:30
@moibra05 moibra05 added this pull request to the merge queue May 27, 2026
Merged via the queue into main with commit 8413097 May 27, 2026
26 checks passed
@moibra05 moibra05 deleted the 15736 branch May 27, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikewilli mikewilli mikewilli approved these changes

@freshstrangemusic freshstrangemusic Awaiting requested review from freshstrangemusic freshstrangemusic is a code owner

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart is a code owner

@yashikakhurana yashikakhurana Awaiting requested review from yashikakhurana yashikakhurana is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Current display of 3-days retention is confusing in the details modal

2 participants

@moibra05 @mikewilli