diff --git a/experimenter/experimenter/nimbus_ui/constants.py b/experimenter/experimenter/nimbus_ui/constants.py index f08f95ed0..9efd5315a 100644 --- a/experimenter/experimenter/nimbus_ui/constants.py +++ b/experimenter/experimenter/nimbus_ui/constants.py @@ -308,6 +308,15 @@ class NimbusUIConstants: MISSING_METRIC_DATA_MESSAGE = """Results for this metric are unavailable because some or all of the required metric data is missing.""" + HIDDEN_DAILY_METRICS = [ + NimbusConstants.RETENTION_3_DAYS, + NimbusConstants.RETENTION_3_DAYS_DESKTOP, + ] + HIDDEN_WEEKLY_METRICS = [ + NimbusConstants.RETENTION_3_DAYS, + NimbusConstants.RETENTION_3_DAYS_DESKTOP, + ] + class MetricAreaType: PRIMARY = { "label": "Primary Metric", diff --git a/experimenter/experimenter/nimbus_ui/templates/common/metric_popout.html b/experimenter/experimenter/nimbus_ui/templates/common/metric_popout.html index 3ba67aa17..d160fb7ad 100644 --- a/experimenter/experimenter/nimbus_ui/templates/common/metric_popout.html +++ b/experimenter/experimenter/nimbus_ui/templates/common/metric_popout.html @@ -106,7 +106,7 @@

Overview

{% with weekly_metric_data=all_weekly_metric_data|dict_get:metric_info.slug %} - {% if weekly_metric_data.has_weekly_data and not metric_info.slug == experiment.RETENTION_3_DAYS %} + {% if weekly_metric_data.has_weekly_data and not metric_info.slug in NimbusUIConstants.HIDDEN_WEEKLY_METRICS %}

Weekly breakdown

@@ -168,7 +168,7 @@

Weekly breakdown

{% endif %} {% endwith %} {% with daily_metric_data=all_daily_metric_data|dict_get:metric_info.slug %} - {% if daily_metric_data.has_daily_data and not metric_info.slug == experiment.RETENTION_3_DAYS %} + {% if daily_metric_data.has_daily_data and not metric_info.slug in NimbusUIConstants.HIDDEN_DAILY_METRICS %}

Daily breakdown