Skip to content

fix(nimbus): hide weekly and daily data for desktop 3dr #15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moibra05 merged 1 commit into from
May 27, 2026
+11 −2
Merged

fix(nimbus): hide weekly and daily data for desktop 3dr #15738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions experimenter/experimenter/nimbus_ui/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,15 @@ class NimbusUIConstants:
MISSING_METRIC_DATA_MESSAGE = """Results for this metric are unavailable because
some or all of the required metric data is missing."""

HIDDEN_DAILY_METRICS = [
NimbusConstants.RETENTION_3_DAYS,
NimbusConstants.RETENTION_3_DAYS_DESKTOP,
]
HIDDEN_WEEKLY_METRICS = [
NimbusConstants.RETENTION_3_DAYS,
NimbusConstants.RETENTION_3_DAYS_DESKTOP,
]

class MetricAreaType:
PRIMARY = {
"label": "Primary Metric",
Expand Down
4 changes: 2 additions & 2 deletions experimenter/experimenter/nimbus_ui/templates/common/metric_popout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ <h2 class="fs-6 fw-bold">Overview</h2>
</div>
</div>
{% with weekly_metric_data=all_weekly_metric_data|dict_get:metric_info.slug %}
{% if weekly_metric_data.has_weekly_data and not metric_info.slug == experiment.RETENTION_3_DAYS %}
{% if weekly_metric_data.has_weekly_data and not metric_info.slug in NimbusUIConstants.HIDDEN_WEEKLY_METRICS %}
<div class="border border-1 rounded py-4 px-5 rounded-4">
<h2 class="fs-6 fw-bold">Weekly breakdown</h2>
<div class="d-flex mt-3">
Expand Down Expand Up @@ -168,7 +168,7 @@ <h2 class="fs-6 fw-bold">Weekly breakdown</h2>
{% endif %}
{% endwith %}
{% with daily_metric_data=all_daily_metric_data|dict_get:metric_info.slug %}
{% if daily_metric_data.has_daily_data and not metric_info.slug == experiment.RETENTION_3_DAYS %}
{% if daily_metric_data.has_daily_data and not metric_info.slug in NimbusUIConstants.HIDDEN_DAILY_METRICS %}
<div class="border border-1 rounded py-4 px-5 rounded-4">
<h2 class="fs-6 fw-bold">Daily breakdown</h2>
<div class="d-flex mt-3">
Expand Down
Loading