Skip to content

feat(nimbus): Add Rollout QA Form/Card#15760

Open
RJAK11 wants to merge 4 commits into
mainfrom
15082
Open

feat(nimbus): Add Rollout QA Form/Card#15760
RJAK11 wants to merge 4 commits into
mainfrom
15082

Conversation

@RJAK11
Copy link
Copy Markdown
Contributor

@RJAK11 RJAK11 commented May 29, 2026

Because

  • We need a QA card for the rollout summary page
  • Users need to view and update QA status and QA notes

This commit

  • Adds the QA card for the rollout summary page

Fixes #15082

Screen.Recording.2026-06-01.at.12.33.38.PM.mov

Because

* We need a QA card for the rollout summary page
* Users need to view and update QA status and QA notes

This commit

* Adds the QA card for the rollout summary page

Fixes #15082
Copy link
Copy Markdown
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RJAK11 overall looks great, just in terms of design in the screen recording I see we have self qa options too, little bit confusing we are giving option for self QA at both the places, we can do 2 things, 1- remove self qa part and just keep the drop down, or we can remove options from the drop down in the first section which have self QA choices

Because

* We need a QA card for the rollout summary page
* Users need to view and update QA status and QA notes

This commit

* Adds the QA card for the rollout summary page

Fixes #15082
@RJAK11
Copy link
Copy Markdown
Contributor Author

RJAK11 commented Jun 1, 2026

Thank you @RJAK11 overall looks great, just in terms of design in the screen recording I see we have self qa options too, little bit confusing we are giving option for self QA at both the places, we can do 2 things, 1- remove self qa part and just keep the drop down, or we can remove options from the drop down in the first section which have self QA choices

@yashikakhurana I removed the self QA section and updated the screen recording. Let me know what you think 🙏

@RJAK11 RJAK11 requested a review from yashikakhurana June 1, 2026 17:14
Copy link
Copy Markdown
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some minor suggestions

Comment thread experimenter/experimenter/nimbus_ui/templates/common/new_sidebar.html Outdated
Comment thread experimenter/experimenter/nimbus_ui/templates/common/new_sidebar.html Outdated
Because

* We need a QA card for the rollout summary page
* Users need to view and update QA status and QA notes

This commit

* Adds the QA card for the rollout summary page

Fixes #15082
@RJAK11 RJAK11 force-pushed the 15082 branch 2 times, most recently from 05231b5 to ab58e24 Compare June 2, 2026 19:46
Because

* We need a QA card for the rollout summary page
* Users need to view and update QA status and QA notes

This commit

* Adds the QA card for the rollout summary page

Fixes #15082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rollout QA Form/Card

2 participants