Skip to content

Commit 9872fbc

Browse files
csamujuliandescottes
authored andcommitted
Code style: break up long constructors into several lines
1 parent 72aba07 commit 9872fbc

2 files changed

Lines changed: 27 additions & 10 deletions

File tree

tests/firefox/pages.test.ts

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,19 @@ describe('PageManagement', () => {
7272
? vi.fn().mockImplementation(overrides.sendBiDiCommand)
7373
: undefined;
7474

75-
const pages = new PageManagement(driver, getCurrentContextId, setCurrentContextId, sendBiDiCommand as any);
76-
return { pages, driver, getCurrentContextId, setCurrentContextId, sendBiDiCommand: sendBiDiCommand as any };
75+
const pages = new PageManagement(
76+
driver,
77+
getCurrentContextId,
78+
setCurrentContextId,
79+
sendBiDiCommand as any
80+
);
81+
return {
82+
pages,
83+
driver,
84+
getCurrentContextId,
85+
setCurrentContextId,
86+
sendBiDiCommand: sendBiDiCommand as any,
87+
};
7788
}
7889

7990
describe('navigate', () => {
@@ -151,7 +162,12 @@ describe('PageManagement', () => {
151162
const getCurrentContextId = vi.fn().mockReturnValue('handle-2');
152163
const setCurrentContextId = vi.fn();
153164

154-
const pages = new PageManagement(driver, getCurrentContextId, setCurrentContextId, bidiFn as any);
165+
const pages = new PageManagement(
166+
driver,
167+
getCurrentContextId,
168+
setCurrentContextId,
169+
bidiFn as any
170+
);
155171

156172
const idx = await pages.createNewPage('moz-extension://abc123/popup.html');
157173

@@ -179,7 +195,12 @@ describe('PageManagement', () => {
179195
const getCurrentContextId = vi.fn().mockReturnValue('handle-2');
180196
const setCurrentContextId = vi.fn();
181197

182-
const pages = new PageManagement(driver, getCurrentContextId, setCurrentContextId, bidiFn as any);
198+
const pages = new PageManagement(
199+
driver,
200+
getCurrentContextId,
201+
setCurrentContextId,
202+
bidiFn as any
203+
);
183204

184205
const idx = await pages.createNewPage('https://example.com');
185206

tests/integration/moz-extension.integration.test.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,7 @@ describe('moz-extension:// Navigation Integration Tests', () => {
128128
// while tolerating slow CI.
129129
const result = await Promise.race([
130130
firefox.navigate(extensionUrl).then(() => 'navigated'),
131-
new Promise<string>((resolve) =>
132-
setTimeout(() => resolve('timeout'), 5000)
133-
),
131+
new Promise<string>((resolve) => setTimeout(() => resolve('timeout'), 5000)),
134132
]);
135133

136134
expect(result).toBe('navigated');
@@ -150,9 +148,7 @@ describe('moz-extension:// Navigation Integration Tests', () => {
150148
it('should create new page with moz-extension:// URL without hanging', async () => {
151149
const result = await Promise.race([
152150
firefox.createNewPage(extensionUrl).then((idx: number) => `created-${idx}`),
153-
new Promise<string>((resolve) =>
154-
setTimeout(() => resolve('timeout'), 5000)
155-
),
151+
new Promise<string>((resolve) => setTimeout(() => resolve('timeout'), 5000)),
156152
]);
157153

158154
expect(result).toMatch(/^created-/);

0 commit comments

Comments
 (0)