Merge pull request #298 from mozilla/strict-switch

Add variable strictness for spec compliance and improve checks

Author: baumanj

mp4parse/benches/avif_benchmark.rs

@@ -19,5 +19,5 @@ fn avif_largest() {
         "av1-avif/testFiles/Netflix/avif/cosmos_frame05000_yuv444_12bpc_bt2020_pq_qlossless.avif",
     )
     .expect("Unknown file");
-    assert!(mp4::read_avif(input).is_ok());
+    assert!(mp4::read_avif(input, mp4::ParseStrictness::Normal).is_ok());
 }

mp4parse/src/boxes.rs

@@ -116,13 +116,16 @@ box_database!(
     MediaHeaderBox                    0x6d64_6864, // "mdhd"
     HandlerBox                        0x6864_6c72, // "hdlr"
     MediaInformationBox               0x6d69_6e66, // "minf"
-    ImageReferenceBox                 0x6972_6566, // "iref"
-    ImagePropertiesBox                0x6970_7270, // "iprp"
+    ItemReferenceBox                  0x6972_6566, // "iref"
+    ItemPropertiesBox                 0x6970_7270, // "iprp"
     ItemPropertyContainerBox          0x6970_636f, // "ipco"
     ItemPropertyAssociationBox        0x6970_6d61, // "ipma"
     ColorInformationBox               0x636f_6c72, // "colr"
     PixelInformationBox               0x7069_7869, // "pixi"
     AuxiliaryTypeProperty             0x6175_7843, // "auxC"
+    CleanApertureBox                  0x636c_6170, // "clap"
+    ImageRotation                     0x6972_6f74, // "irot"
+    ImageMirror                       0x696d_6972, // "imir"
     SampleTableBox                    0x7374_626c, // "stbl"
     SampleDescriptionBox              0x7374_7364, // "stsd"
     TimeToSampleBox                   0x7374_7473, // "stts"

mp4parse/src/lib.rs

@@ -426,7 +426,7 @@ fn read_vpcc_version_0() {
 
 // TODO: it'd be better to find a real sample here.
 #[test]
-#[allow(clippy::inconsistent_digit_grouping)] // Allow odd grouping for test readability.
+#[allow(clippy::unusual_byte_groupings)] // Allow odd grouping for test readability.
 fn read_vpcc_version_1() {
     let data_length = 12u16;
     let mut stream = make_fullbox(BoxSize::Auto, b"vpcC", 1, |s| {