Minor FFI hardening fixes#443
Open
kinetiknz wants to merge 6 commits into
Open
Conversation
indices.
kinetiknz
force-pushed
the
get_indice_table
branch
2 times, most recently
from
April 14, 2026 04:32
fab9041 to
97f1cc1
Compare
…ary. QuickTime v2 audio sample entries can carry a u32 channel count and f64 sample rate that don't fit the u16/u32 C-API fields. Replace the silent truncating casts with checked conversions that return Invalid.
…mented. Both functions dereferenced their out-pointer without first checking for null, unlike every other C API entry point. Add the missing guards so callers that pass null get BadArg instead of a null-deref.
Matches the pattern used by all other FFI getters, ensuring C callers always see valid (zeroed) fields even on error paths.
kinetiknz
force-pushed
the
get_indice_table
branch
from
June 15, 2026 03:34
97f1cc1 to
fb271cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny defensive changes:
avif_infoandavif_imagewith defaults to match other code and avoid exposing uninitialized structs on error pathstimescalesilentlyreadcallback misbehaviour