Skip to content

Fix 1822: Sync container colors with Firefox container settings #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nekno wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix 1822: Sync container colors with Firefox container settings #2841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
885949b
Add `toolbar` color (appears as the primary text color) to match hard…
nekno Jan 5, 2026
49d1537
Flex to fit 9 color icons per row. Ensure the `toolbar` color matches…
nekno Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/css/popup.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
--icon-button-size: calc(calc(var(--block-line-separation-size) * 2) + 1.66rem); /* 20px */
--inactive-opacity: 0.3;
--overflow-size: 1px;
--icon-fit: 8;
--icon-fit: 9;
Copy link
Copy Markdown
Contributor Author

@nekno nekno Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to just be hardcoded to match the number of colors. Each color swatch is 32 x 32px, and the panel is 320px wide, so you can fit 10 colors in a row without compromising on minimum spacing/padding on anything.

This changes it from 8 to 9 so all colors fit on the same row, and the minimum spacing is still met.


background: var(--bgColor);
margin-block: 0;
Expand Down Expand Up @@ -392,6 +392,11 @@ table {
--identity-icon-color: #af51f5;
}

[data-identity-color="toolbar"] {
--identity-tab-color: currentColor;
--identity-icon-color: currentColor;
}

Copy link
Copy Markdown
Contributor Author

@nekno nekno Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the Firefox stylesheet for the ContextualIdentity component.

[data-identity-icon="fingerprint"] {
--identity-icon: url("/img/usercontext.svg#fingerprint");
}
Expand Down
2 changes: 1 addition & 1 deletion src/js/popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,7 @@
const td = document.createElement("td");
const openTabs = identity.numberOfOpenTabs || "" ;

// TODO get UX and content decision on how to message and block clicks to containers with Mozilla VPN proxy configs

Check warning on line 827 in src/js/popup.js

View workflow job for this annotation

GitHub Actions / Run tests 

Unexpected 'todo' comment: 'TODO get UX and content decision on how...'
// when Mozilla VPN app is disconnected.

td.innerHTML = Utils.escaped`
Expand Down Expand Up @@ -1889,7 +1889,7 @@
return Utils.escaped`<input type="radio" value="${containerColor}" name="container-color" id="edit-container-panel-choose-color-${containerColor}" />
<label for="edit-container-panel-choose-color-${containerColor}" class="usercontext-icon choose-color-icon" data-identity-icon="circle" data-identity-color="${containerColor}">`;
};
const colors = ["blue", "turquoise", "green", "yellow", "orange", "red", "pink", "purple"];
const colors = ["blue", "turquoise", "green", "yellow", "orange", "red", "pink", "purple", "toolbar"];
Copy link
Copy Markdown
Contributor Author

@nekno nekno Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the toolbar color named in the Firefox container settings dialog.

const colorRadioFieldset = document.getElementById("edit-container-panel-choose-color");
colors.forEach((containerColor) => {
const templateInstance = document.createElement("div");
Expand Down
Loading