Fix #2699: Prevent trashcan from being obscured by scrollbar#2868
Open
LuciferDono wants to merge 1 commit into
Open
Fix #2699: Prevent trashcan from being obscured by scrollbar#2868LuciferDono wants to merge 1 commit into
LuciferDono wants to merge 1 commit into
Conversation
Collaborator
|
Can you please attach a screenshot before and after? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your pull request
npm testand all tests passed.Description
When users have "Always show scrollbars" enabled in their OS settings, the trashcan (delete) and reset buttons on assigned site list rows are partly hidden behind the visible scrollbar.
Root cause:
.truncate-textusedinline-size: calc(100vw - 100px), which bases the width on the full viewport — including the area consumed by the scrollbar. This forced the text span to a fixed width that overflows the flex container when a scrollbar is present, pushing the action buttons behind it.Fix: Replace the fixed
calc()width withmin-inline-size: 0, which is the standard CSS fix for allowing flex items to shrink below their content size. The parent<td>already usesdisplay: flexand.menu-textalready hasflex: 1, so the text span now naturally fills only the remaining space after the favicon and buttons — regardless of whether a scrollbar is visible.Type of change
Fixes #2699