Skip to content

Commit d13c28a

Browse files
committed
Change Promise-returning worker message-handler functions to be asynchronous
A number of these functions are old enough that they predate async/await, and making them asynchronous is ever so slightly shorter/simpler.
1 parent f0b5fc3 commit d13c28a

1 file changed

Lines changed: 41 additions & 43 deletions

File tree

src/core/worker.js

Lines changed: 41 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -391,23 +391,22 @@ class WorkerMessageHandler {
391391
.then(pdfManagerReady, onFailure);
392392
}
393393

394-
handler.on("GetPage", function ({ pageIndex }) {
395-
return pdfManager.getPage(pageIndex).then(function (page) {
396-
return Promise.all([
397-
pdfManager.ensure(page, "rotate"),
398-
pdfManager.ensure(page, "ref"),
399-
pdfManager.ensure(page, "userUnit"),
400-
pdfManager.ensure(page, "view"),
401-
]).then(function ([rotate, ref, userUnit, view]) {
402-
return {
403-
rotate,
404-
ref,
405-
refStr: ref?.toString() ?? null,
406-
userUnit,
407-
view,
408-
};
409-
});
410-
});
394+
handler.on("GetPage", async function ({ pageIndex }) {
395+
const page = await pdfManager.getPage(pageIndex);
396+
397+
const [rotate, ref, userUnit, view] = await Promise.all([
398+
pdfManager.ensure(page, "rotate"),
399+
pdfManager.ensure(page, "ref"),
400+
pdfManager.ensure(page, "userUnit"),
401+
pdfManager.ensure(page, "view"),
402+
]);
403+
return {
404+
rotate,
405+
ref,
406+
refStr: ref?.toString() ?? null,
407+
userUnit,
408+
view,
409+
};
411410
});
412411

413412
handler.on("GetPageIndex", function ({ num, gen }) {
@@ -472,10 +471,9 @@ class WorkerMessageHandler {
472471
return pdfManager.ensureCatalog("jsActions");
473472
});
474473

475-
handler.on("GetPageJSActions", function ({ pageIndex }) {
476-
return pdfManager
477-
.getPage(pageIndex)
478-
.then(page => pdfManager.ensure(page, "jsActions"));
474+
handler.on("GetPageJSActions", async function ({ pageIndex }) {
475+
const page = await pdfManager.getPage(pageIndex);
476+
return pdfManager.ensure(page, "jsActions");
479477
});
480478

481479
handler.on(
@@ -550,25 +548,27 @@ class WorkerMessageHandler {
550548
return pdfManager.ensureCatalog("markInfo");
551549
});
552550

553-
handler.on("GetData", function () {
554-
return pdfManager.requestLoadedStream().then(stream => stream.bytes);
551+
handler.on("GetData", async function () {
552+
const stream = await pdfManager.requestLoadedStream();
553+
return stream.bytes;
555554
});
556555

557-
handler.on("GetAnnotations", function ({ pageIndex, intent }) {
558-
return pdfManager.getPage(pageIndex).then(function (page) {
559-
const task = new WorkerTask(`GetAnnotations: page ${pageIndex}`);
560-
startWorkerTask(task);
556+
handler.on("GetAnnotations", async function ({ pageIndex, intent }) {
557+
const page = await pdfManager.getPage(pageIndex);
561558

562-
return page.getAnnotationsData(handler, task, intent).finally(() => {
563-
finishWorkerTask(task);
564-
});
565-
});
559+
const task = new WorkerTask(`GetAnnotations: page ${pageIndex}`);
560+
startWorkerTask(task);
561+
562+
try {
563+
return await page.getAnnotationsData(handler, task, intent);
564+
} finally {
565+
finishWorkerTask(task);
566+
}
566567
});
567568

568-
handler.on("GetFieldObjects", function () {
569-
return pdfManager
570-
.ensureDoc("fieldObjects")
571-
.then(fieldObjects => fieldObjects?.allFields || null);
569+
handler.on("GetFieldObjects", async function () {
570+
const fieldObjects = await pdfManager.ensureDoc("fieldObjects");
571+
return fieldObjects?.allFields || null;
572572
});
573573

574574
handler.on("GetSignatures", function () {
@@ -975,10 +975,9 @@ class WorkerMessageHandler {
975975
}
976976
);
977977

978-
handler.on("GetStructTree", function ({ pageIndex }) {
979-
return pdfManager
980-
.getPage(pageIndex)
981-
.then(page => pdfManager.ensure(page, "getStructTree"));
978+
handler.on("GetStructTree", async function ({ pageIndex }) {
979+
const page = await pdfManager.getPage(pageIndex);
980+
return pdfManager.ensure(page, "getStructTree");
982981
});
983982

984983
handler.on("FontFallback", function ({ id }) {
@@ -1049,10 +1048,9 @@ class WorkerMessageHandler {
10491048
handler.on("GetStartXRefPos", function () {
10501049
return pdfManager.ensureDoc("startXRef");
10511050
});
1052-
handler.on("GetAnnotArray", function ({ pageIndex }) {
1053-
return pdfManager
1054-
.getPage(pageIndex)
1055-
.then(page => page.annotations.map(a => a.toString()));
1051+
handler.on("GetAnnotArray", async function ({ pageIndex }) {
1052+
const page = await pdfManager.getPage(pageIndex);
1053+
return page.annotations.map(a => a.toString());
10561054
});
10571055
handler.on("GetWorkerCoverage", function () {
10581056
return globalThis.__coverage__ ?? {};

0 commit comments

Comments
 (0)