[api-minor] Use the ImageDecoder by default on Chrome#20961
[api-minor] Use the ImageDecoder by default on Chrome#20961Snuffleupagus merged 1 commit intomozilla:masterfrom
Conversation
The two mentioned bugs have been fixed a while back. So it should be fine to use this feature now.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20961 +/- ##
==========================================
+ Coverage 62.51% 62.55% +0.04%
==========================================
Files 172 172
Lines 121789 121771 -18
==========================================
+ Hits 76134 76179 +45
+ Misses 45655 45592 -63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yes, but also kind of no :-) https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support still lists Chrome 118 as supported, however the referenced bugs weren't fixed until somewhere around Chrome 132-133 (I think), |
Snuffleupagus
left a comment
There was a problem hiding this comment.
r=me, assuming that you're OK with this potentially increasing the effort required when triaging issues.
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with passing tests. Thanks!
|
Let's try to land this now since the minimum supported Chrome version was just updated to 125, which is much closer to the versions where those bugs are fixed (reducing the risk of issues reported here), in combination with the major PDF.js version number just being increased. |
The two mentioned bugs have been fixed a while back. So it should be fine to use this feature now.