Collect coverage information for the integration tests

[timvandermeij]

Note that for the integration tests the coverage information ends up being processed in the Node.js context where window is not available, so we use globalThis instead for the function that merges individual test's coverage information into the global object because that is available in all contexts we support. For clarity we also rename said function since we're not exclusively dealing with window nor worker data anymore.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.54%. Comparing base (ac51bdf) to head (d6916ac).

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #21173       +/-   ##
===========================================
+ Coverage   55.92%   74.54%   +18.61%     
===========================================
  Files         220      254       +34     
  Lines       58990    64614     +5624     
===========================================
+ Hits        32993    48167    +15174     
+ Misses      25997    16447     -9550     

Flag	Coverage Δ
fonttest	8.65% <ø> (ø)
integrationtest	76.18% <ø> (?)
unittest	55.19% <ø> (-0.02%)	⬇️
unittestcli	55.66% <ø> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Snuffleupagus]

Possibly a stupid idea: Given how slow the Windows/Chrome integration-tests become, how about keeping that particular combination running without coverage?

[calixteman]

Possibly a stupid idea: Given how slow the Windows/Chrome integration-tests become, how about keeping that particular combination running without coverage?

I'm not opposed.
But in the mean time having them could help to us to have some hints on what can be improved and maybe this combination could highlight some bottlenecks.

[Snuffleupagus]

The failing integration-test actually looks like a pre-existing intermittent failure, given that the very same test just failed in PR #21214 for the same OS/browser combination.

Maybe that test should be marked as pending in the affected environment, and a tracking issue opened, such that this nice PR can finally land?

[timvandermeij]

Thank you for reporting this. I have done some digging into this intermittent and created #21217 for it: fortunately it's reproducible locally and it's clear what the problem is (duplicated text layer content for page editing operations), but I haven't been able to figure out how that can happen yet.

In any case, it's not a blocker for this PR because it's a pre-existing issue. This PR is mostly ready, but there are a few things left I need to fix before putting this up for review.

[timvandermeij]

#21217 is fixed, so I have rebased this PR and included the final changes I still needed to make here, so it should be ready for review now.

[calixteman]

You overlooked worker coverage, right ?

[timvandermeij]

Hm, good point; looks like I did. I'll have to think a bit about how to do that here.

[calixteman]

You could have something like in closeSinglePage:

 const result = await page.evaluate(async () => {
    let workerCoverage = null;
    const handler =
      window.PDFViewerApplication.pdfDocument?._transport?.messageHandler;
    if (handler) {
      try {
        workerCoverage = await handler.sendWithPromise("GetWorkerCoverage", null);
      } catch {}
    }
    await window.PDFViewerApplication.testingClose();
    window.localStorage.clear();
    return {
      page: window.__coverage__ ? JSON.stringify(window.__coverage__) : null,
      worker: workerCoverage ? JSON.stringify(workerCoverage) : null,
    };
  });
  if (result.page) mergeCoverageIntoGlobal(JSON.parse(result.page));
  if (result.worker) mergeCoverageIntoGlobal(JSON.parse(result.worker));