Skip to content

Clear the text layer container when cancelling rendering#21219

Merged
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:issue21217
May 5, 2026
Merged

Clear the text layer container when cancelling rendering#21219
timvandermeij merged 1 commit intomozilla:masterfrom
calixteman:issue21217

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

It fixes #21217.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 4, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.90%. Comparing base (a55cec4) to head (82f55e7).

Files with missing lines Patch % Lines
web/text_layer_builder.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21219      +/-   ##
==========================================
- Coverage   55.97%   55.90%   -0.07%     
==========================================
  Files         218      218              
  Lines       59033    59035       +2     
==========================================
- Hits        33041    33004      -37     
- Misses      25992    26031      +39     
Flag Coverage Δ
fonttest ?
unittest 55.21% <0.00%> (-0.02%) ⬇️
unittestcli 55.69% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij merged commit a1d9f13 into mozilla:master May 5, 2026
17 of 18 checks passed
@timvandermeij
Copy link
Copy Markdown
Contributor

I have confirmed locally that this fixes the root cause of the mentioned test in the issue as well as the ~10 other tests in the reorganize pages suite that also failed if this delay was introduced. Really great that this is fixed now; thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Intermittent failures in reorganize_pages_spec if text layer rendering is delayed

3 participants