A couple of small tweaks of the getPdfFilenameFromUrl helper#21222
Merged
timvandermeij merged 1 commit intomozilla:masterfrom May 5, 2026
Merged
Conversation
- Shorten the `getURL` function slightly, by re-factoring the try-catch blocks. - Change how the `decode` function looks for a decoded ".pdf" name, to skip the regular expression matching when it's not needed and to allow re-using the already defined `pdfRegex`.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21222 +/- ##
==========================================
- Coverage 55.97% 55.96% -0.01%
==========================================
Files 218 218
Lines 59033 59033
==========================================
- Hits 33041 33037 -4
- Misses 25992 25996 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a67897d to
8fc5677
Compare
timvandermeij
approved these changes
May 5, 2026
Contributor
timvandermeij
left a comment
There was a problem hiding this comment.
r=me; thank you for flattening this code a bit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getURLfunction slightly, by re-factoring the try-catch blocks.decodefunction looks for a decoded ".pdf" name, to skip the regular expression matching when it's not needed and to allow re-using the already definedpdfRegex.Smaller diff with https://github.com/mozilla/pdf.js/pull/21222/changes?w=1