Make sure the focus moves on the first page of the added pdf after a merge (bug 2034827)#21223
Open
calixteman wants to merge 1 commit intomozilla:masterfrom
Open
Make sure the focus moves on the first page of the added pdf after a merge (bug 2034827)#21223calixteman wants to merge 1 commit intomozilla:masterfrom
calixteman wants to merge 1 commit intomozilla:masterfrom
Conversation
…merge (bug 2034827)
Contributor
Author
|
FYI, I didn't manage to have an integration test reproducing the issue. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21223 +/- ##
==========================================
- Coverage 55.94% 55.90% -0.05%
==========================================
Files 219 219
Lines 59017 59017
==========================================
- Hits 33020 32992 -28
- Misses 25997 26025 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| this._mergedDocumentNeedsSaving = true; | ||
|
|
||
| // The following line is necessary to fix bug 2034827. | ||
| // TODO: create an integration test that covers this case. |
Contributor
There was a problem hiding this comment.
I'm not entirely clear on why this TODO is here given that this commit already extends the integration tests above to cover this case?
Aside from that, why does clearing the history here change the focus? It might be good to extend that part of the comment a bit, to indicate what the effect of this is in addition to the bug number it fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.