Skip to content

Make sure the focus moves on the first page of the added pdf after a merge (bug 2034827) #21223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calixteman wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

Make sure the focus moves on the first page of the added pdf after a merge (bug 2034827) #21223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/integration/reorganize_pages_spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3084,6 +3084,12 @@ describe("Reorganize Pages View", () => {
() => parseInt(document.getElementById("pageNumber").max, 10) === 6
);

// Focus must move to the first newly inserted page (page 3, since
// we merged after page 2).
await page.waitForFunction(
() => window.PDFViewerApplication.page === 3
);

// Pages 1–2 come from the original document, then all 3 pages of
// the merged PDF, then pages 4–6 of the original shifted to the end.
await waitForHavingContents(page, [1, 2, 1, 2, 3, 3]);
Expand Down
5 changes: 5 additions & 0 deletions web/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2440,6 +2440,11 @@ const PDFViewerApplication = {
return;
}
this._mergedDocumentNeedsSaving = true;

// The following line is necessary to fix bug 2034827.
// TODO: create an integration test that covers this case.
Copy link
Copy Markdown
Contributor

@timvandermeij timvandermeij May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely clear on why this TODO is here given that this commit already extends the integration tests above to cover this case?

Aside from that, why does clearing the history here change the focus? It might be good to extend that part of the comment a bit, to indicate what the effect of this is in addition to the bug number it fixes.

this.pdfHistory = null;

this.open({
data: modifiedPdfBytes,
filename: this._docFilename,
Expand Down
Loading