Skip to content

Add support for encrypted attachments#21234

Open
wooorm wants to merge 1 commit into
mozilla:masterfrom
wooorm:wooorm/encrypted-attachments
Open

Add support for encrypted attachments#21234
wooorm wants to merge 1 commit into
mozilla:masterfrom
wooorm:wooorm/encrypted-attachments

Conversation

@wooorm
Copy link
Copy Markdown
Collaborator

@wooorm wooorm commented May 7, 2026

This PR is related to GH-20732, which is about AuthEvent (to delay promting for a password), but instead adds the actual support for encrypted attachments.
“Encrypted attachments” means that the main things are plain text. Note that some PDF viewers, like Preview/QuickLook/Safari or Chrome, do not support attachments at all.
Also note that the file checked into the tests is the same as output-no-auth-event.pdf referenced in
#20139 (comment).

Closes GH-20139.

@wooorm wooorm temporarily deployed to code-coverage May 7, 2026 11:42 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 7, 2026 11:42 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 7, 2026 11:42 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 7, 2026 11:42 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 7, 2026 11:42 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 7, 2026 11:42 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 7, 2026 11:42 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 7, 2026 11:42 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 7, 2026 11:42 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 7, 2026 11:42 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 7, 2026 11:42 — with GitHub Actions Inactive
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 7, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.19%. Comparing base (bf9ae76) to head (64ecd4c).

Files with missing lines Patch % Lines
src/core/parser.js 88.46% 3 Missing ⚠️
src/core/crypto.js 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21234      +/-   ##
==========================================
+ Coverage   54.70%   56.19%   +1.49%     
==========================================
  Files         216      220       +4     
  Lines       59131    59257     +126     
==========================================
+ Hits        32347    33301     +954     
+ Misses      26784    25956     -828     
Flag Coverage Δ
fonttest 8.64% <0.00%> (?)
unittest 55.46% <91.66%> (?)
unittestcli 54.74% <91.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This PR is related to mozillaGH-20732, which is about `AuthEvent` (to delay
promting for a password), but instead adds the actual support for
encrypted attachments.
“Encrypted attachments” means that the main things are plain text.
Note that some PDF viewers, like Preview/QuickLook/Safari or Chrome,
do not support attachments at all.
Note that the file checked into the tests is the same as
`output-no-auth-event.pdf` referenced in
<mozilla#20139 (comment)>.

Closes mozillaGH-20139.
@wooorm wooorm force-pushed the wooorm/encrypted-attachments branch from a618a1f to 64ecd4c Compare May 13, 2026 13:27
@wooorm wooorm temporarily deployed to code-coverage May 13, 2026 13:27 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 13, 2026 13:27 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 13, 2026 13:27 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 13, 2026 13:27 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 13, 2026 13:27 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 13, 2026 13:27 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 13, 2026 13:27 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 13, 2026 13:27 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 13, 2026 13:27 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 13, 2026 13:27 — with GitHub Actions Inactive
@wooorm wooorm temporarily deployed to code-coverage May 13, 2026 13:27 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: File Attachments do not open when they are encrypted

3 participants