Fix nested non-isolated groups in knockout rendering#21262
Conversation
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/64ea5cd4b01ab13/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c6069faf92d03b2/output.txt |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21262 +/- ##
==========================================
+ Coverage 56.17% 56.18% +0.01%
==========================================
Files 220 220
Lines 59234 59233 -1
==========================================
+ Hits 33273 33279 +6
+ Misses 25961 25954 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c6069faf92d03b2/output.txt Total script time: 18.52 mins
Image differences available at: http://54.241.84.105:8877/c6069faf92d03b2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/64ea5cd4b01ab13/output.txt Total script time: 24.29 mins
Image differences available at: http://54.193.163.58:8877/64ea5cd4b01ab13/reftest-analyzer.html#web=eq.log |
|
The "regression" in knockout_groups_test.pdf is a bug fix: I compared with Acrobat and Foxit. |
timvandermeij
left a comment
timvandermeij
left a comment
There was a problem hiding this comment.
r=me, with the comment addressed. Thank you for fixing this!
It fixes mozilla#18032. Only use the special inner-backdrop compositing path for nested non-isolated groups that actually need isolation. This preserves the parent/page backdrop for simple nested groups inside knockout groups, preventing later group compositing from erasing existing backdrop content.
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f1a65e35ec00e2c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ceebd96b6462d13/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f1a65e35ec00e2c/output.txt Total script time: 18.51 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/ceebd96b6462d13/output.txt Total script time: 24.33 mins
|
4 participants
It fixes #18032.
Only use the special inner-backdrop compositing path for nested non-isolated groups that actually need isolation. This preserves the parent/page backdrop for simple nested groups inside knockout groups, preventing later group compositing from erasing existing backdrop content.