Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/display/canvas.js
Original file line number Diff line number Diff line change
Expand Up @@ -3342,13 +3342,15 @@ class CanvasGraphics {
// #compositeKnockoutSurface so it doesn't become part of the group
// source itself.
const backdropCtx = group.knockout && !group.isolated ? currentCtx : null;
// Non-isolated non-KO subgroup inside a KO parent: at endGroup we'll
// blend its elements against the outer KO running canvas (also frozen),
// so just record the flag here and read ctx.canvas at composite time.
// Non-isolated non-KO subgroup inside a KO parent, with inner compositing
// of its own: at endGroup we'll blend its elements against the outer KO
// running canvas (also frozen), so just record the flag here and read
// ctx.canvas at composite time.
const hasInnerBackdrop =
!group.isolated &&
!group.knockout &&
!group.smask &&
group.needsIsolation &&
this.#knockoutGroupLevel > 0;

// Pool the per-element shape mask for the lifetime of this KO group.
Expand Down
1 change: 1 addition & 0 deletions test/pdfs/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -920,3 +920,4 @@
!smask_luminosity_oob_transfer.pdf
!operator_list_cycle.pdf
!knockout_groups_test.pdf
!issue18032.pdf
Binary file added test/pdfs/issue18032.pdf
Comment thread
calixteman marked this conversation as resolved.
Binary file not shown.
8 changes: 8 additions & 0 deletions test/test_manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -14252,5 +14252,13 @@
"rounds": 1,
"type": "eq",
"about": "Knockout groups composite-modes survey."
},
{
"id": "issue18032",
"file": "pdfs/issue18032.pdf",
"md5": "656234fde97953c4e3fc7698831590a9",
"rounds": 1,
"type": "eq",
"about": "Non-isolated knockout group with a nested non-isolated subgroup over existing text."
}
]
Loading