Skip to content

[Editor] Avoid "generating" the l10n-ids used for the a11yAlert#21263

Merged
calixteman merged 1 commit into
mozilla:masterfrom
Snuffleupagus:editor-_l10nAlert
May 12, 2026
Merged

[Editor] Avoid "generating" the l10n-ids used for the a11yAlert#21263
calixteman merged 1 commit into
mozilla:masterfrom
Snuffleupagus:editor-_l10nAlert

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

In the DrawingEditor.prototype.#createDrawOutlines method the l10n-id was being "generated", which is bad for maintainability since searching for l10n-id becomes more difficult and the gulp check_l10n script actually warns about this.

Hence, similar to e.g. the resizer localization, let's define the a11yAlert l10n-ids once and provide shorthands for accessing them.

In the `DrawingEditor.prototype.#createDrawOutlines` method the l10n-id was being "generated", which is bad for maintainability since searching for l10n-id becomes more difficult and the `gulp check_l10n` script actually warns about this.

Hence, similar to e.g. the resizer localization, let's define the `a11yAlert` l10n-ids *once* and provide shorthands for accessing them.
@codecov-commenter

codecov-commenter commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.17%. Comparing base (0c66063) to head (4072d3f).

Files with missing lines Patch % Lines
src/display/editor/editor.js 33.33% 2 Missing ⚠️
src/display/editor/draw.js 0.00% 1 Missing ⚠️
src/display/editor/freetext.js 0.00% 1 Missing ⚠️
src/display/editor/highlight.js 0.00% 1 Missing ⚠️
src/display/editor/stamp.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21263   +/-   ##
=======================================
  Coverage   56.17%   56.17%           
=======================================
  Files         220      220           
  Lines       59234    59236    +2     
=======================================
+ Hits        33273    33276    +3     
+ Misses      25961    25960    -1     
Flag Coverage Δ
fonttest 8.64% <ø> (ø)
unittest 55.45% <14.28%> (+<0.01%) ⬆️
unittestcli 54.70% <14.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks!

@calixteman calixteman merged commit 0e0f7b7 into mozilla:master May 12, 2026
28 of 30 checks passed
@Snuffleupagus Snuffleupagus deleted the editor-_l10nAlert branch May 13, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants