[Editor] Avoid "generating" the l10n-ids used for the a11yAlert#21263
Merged
Conversation
In the `DrawingEditor.prototype.#createDrawOutlines` method the l10n-id was being "generated", which is bad for maintainability since searching for l10n-id becomes more difficult and the `gulp check_l10n` script actually warns about this. Hence, similar to e.g. the resizer localization, let's define the `a11yAlert` l10n-ids *once* and provide shorthands for accessing them.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21263 +/- ##
=======================================
Coverage 56.17% 56.17%
=======================================
Files 220 220
Lines 59234 59236 +2
=======================================
+ Hits 33273 33276 +3
+ Misses 25961 25960 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
May 12, 2026
timvandermeij
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me; thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
DrawingEditor.prototype.#createDrawOutlinesmethod the l10n-id was being "generated", which is bad for maintainability since searching for l10n-id becomes more difficult and thegulp check_l10nscript actually warns about this.Hence, similar to e.g. the resizer localization, let's define the
a11yAlertl10n-ids once and provide shorthands for accessing them.