Skip to content

Rename "Symbol"-named embedded fonts to avoid Windows substitution #21326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
calixteman wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Draft

Rename "Symbol"-named embedded fonts to avoid Windows substitution #21326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/core/fonts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3187,9 +3187,23 @@ class Font {
} else {
// ... using existing 'name' table as prototype
const [namePrototype, nameRecords] = readNameTable(tables.name);
this.psName = namePrototype[0][6] || null;

// Edge on Windows substitutes the system Symbol font for any embedded
// font whose name table identifies it as "Symbol"/"SymbolMT", ignoring
// the embedded glyphs. Overwrite the family/full/PostScript name
// entries with the unique `loadedName` so the regenerated name table
// cannot collide with the system font, mirroring what Firefox does for
// downloadable @font-face fonts (gfxFontUtils::RenameFont).
const family = namePrototype[1][1] || namePrototype[0][1] || "";
if (/^symbol/i.test(family) || /^symbol/i.test(this.psName || "")) {
for (const id of [1, 4, 6]) {
namePrototype[0][id] = this.loadedName;
namePrototype[1][id] = this.loadedName;
}
}

tables.name.data = createNameTable(name, namePrototype);
this.psName = namePrototype[0][6] || null;

if (!properties.composite) {
// For TrueType fonts that do not include `ToUnicode` or `Encoding`
Expand Down
Loading