Skip to content

Bug 2035251 - Use toolkit's pdf icon as favicon#21358

Merged
calixteman merged 1 commit into
mozilla:masterfrom
sfoster:bug-203525-viewer-favicon
Jun 4, 2026
Merged

Bug 2035251 - Use toolkit's pdf icon as favicon#21358
calixteman merged 1 commit into
mozilla:masterfrom
sfoster:bug-203525-viewer-favicon

Conversation

@sfoster

@sfoster sfoster commented May 29, 2026

Copy link
Copy Markdown
Contributor

Should follow https://phabricator.services.mozilla.com/D303238 which will hopefully land land the new pdf.svg icon

@codecov-commenter

codecov-commenter commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (7f15bd6) to head (b9e3a6b).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21358      +/-   ##
==========================================
+ Coverage   89.47%   89.55%   +0.08%     
==========================================
  Files         260      260              
  Lines       65920    65987      +67     
==========================================
+ Hits        58980    59097     +117     
+ Misses       6940     6890      -50     
Flag Coverage Δ
browsertest 66.79% <ø> (+0.17%) ⬆️
integrationtest 66.67% <ø> (-0.06%) ⬇️
unittest 57.03% <ø> (+0.02%) ⬆️
unittestcli 55.98% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread web/viewer.html Outdated
@sfoster sfoster force-pushed the bug-203525-viewer-favicon branch from 3660498 to f457cbe Compare June 3, 2026 21:51
@sfoster sfoster temporarily deployed to code-coverage June 3, 2026 21:51 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 3, 2026 21:51 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 3, 2026 21:51 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 3, 2026 21:51 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 3, 2026 21:51 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 3, 2026 21:51 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 3, 2026 21:51 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 3, 2026 21:51 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 3, 2026 21:51 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 3, 2026 21:51 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 3, 2026 21:51 — with GitHub Actions Inactive
@sfoster

sfoster commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Ok thanks for pointing out the #if MOZCENTRAL thing. Fixed.

Comment thread web/viewer.html Outdated
@sfoster sfoster force-pushed the bug-203525-viewer-favicon branch from f457cbe to b9e3a6b Compare June 4, 2026 18:59
@sfoster sfoster temporarily deployed to code-coverage June 4, 2026 18:59 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 4, 2026 18:59 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 4, 2026 18:59 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 4, 2026 18:59 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 4, 2026 18:59 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 4, 2026 18:59 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 4, 2026 18:59 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 4, 2026 18:59 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 4, 2026 18:59 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 4, 2026 18:59 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 4, 2026 18:59 — with GitHub Actions Inactive
@sfoster sfoster temporarily deployed to code-coverage June 4, 2026 18:59 — with GitHub Actions Inactive

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman merged commit 091f459 into mozilla:master Jun 4, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants