Skip to content

Deduplicate shared font/image streams when merging PDFs#21379

Open
calixteman wants to merge 1 commit into
mozilla:masterfrom
calixteman:dedup_stream_merging
Open

Deduplicate shared font/image streams when merging PDFs#21379
calixteman wants to merge 1 commit into
mozilla:masterfrom
calixteman:dedup_stream_merging

Conversation

@calixteman
Copy link
Copy Markdown
Contributor

Identical embedded fonts and images across the merged documents are now written once and shared, instead of being copied per source file. And avoid to compress already compressed stream with Brotli.

Identical embedded fonts and images across the merged documents are now
written once and shared, instead of being copied per source file.
And avoid to compress already compressed stream with Brotli.
@calixteman calixteman requested a review from timvandermeij June 2, 2026 20:13
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 2, 2026

Codecov Report

❌ Patch coverage is 90.54054% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.44%. Comparing base (b43ef1c) to head (1a7821a).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/core/editor/pdf_editor.js 90.41% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21379      +/-   ##
==========================================
- Coverage   81.45%   81.44%   -0.01%     
==========================================
  Files         260      260              
  Lines       65806    65910     +104     
==========================================
+ Hits        53601    53683      +82     
- Misses      12205    12227      +22     
Flag Coverage Δ
fonttest 9.06% <ø> (ø)
integrationtest 66.67% <0.00%> (-0.07%) ⬇️
unittest 57.04% <90.54%> (+<0.01%) ⬆️
unittestcli 55.99% <90.54%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants