Skip to content

Remove the #externalHide field from the AnnotationLayerBuilder class#21380

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:AnnotationLayerBuilder-rm-#externalHide
Jun 4, 2026
Merged

Remove the #externalHide field from the AnnotationLayerBuilder class#21380
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:AnnotationLayerBuilder-rm-#externalHide

Conversation

@Snuffleupagus

@Snuffleupagus Snuffleupagus commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Prior to PR #20321 the annotationLayer was hidden when there was no regular annotations on the page, which meant that if there were any inferred links (from the textLayer) the annotationLayer needed to be made visible but in such a way that it wouldn't override an explicit hide-call from the PDFPageView class.

With the changes in the aforementioned PR the annotationLayer is now always "visible", and this code can thus be simplified a little bit.

Prior to PR 20321 the annotationLayer was hidden when there was no regular annotations on the page, which meant that if there were any inferred links (from the textLayer) the annotationLayer needed to be made visible but in such a way that it wouldn't override an explicit `hide`-call from the `PDFPageView` class.

With the changes in the aforementioned PR the annotationLayer is now always "visible", and this code can thus be simplified a little bit.
@codecov-commenter

codecov-commenter commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.45%. Comparing base (19046a6) to head (5907d87).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21380      +/-   ##
==========================================
+ Coverage   81.43%   81.45%   +0.01%     
==========================================
  Files         260      260              
  Lines       65843    65839       -4     
==========================================
+ Hits        53617    53626       +9     
+ Misses      12226    12213      -13     
Flag Coverage Δ
integrationtest 66.73% <ø> (+0.01%) ⬆️
unittest 57.03% <ø> (+0.02%) ⬆️
unittestcli 55.96% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij merged commit d619ff3 into mozilla:master Jun 4, 2026
21 of 22 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Looks good; thanks!

@Snuffleupagus Snuffleupagus deleted the AnnotationLayerBuilder-rm-#externalHide branch June 4, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants