Implement unit tests for the getRotationMatrix core utility function#21547
Merged
Conversation
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
had a problem deploying
to
code-coverage
GitHub Actions
Error
timvandermeij
had a problem deploying
to
code-coverage
GitHub Actions
Error
timvandermeij
had a problem deploying
to
code-coverage
GitHub Actions
Failure
timvandermeij
had a problem deploying
to
code-coverage
GitHub Actions
Failure
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
had a problem deploying
to
code-coverage
GitHub Actions
Failure
This function is mostly covered indirectly by higher-level tests, but unlike the other core utility functions it lacked dedicated unit tests. This commit implements unit tests for it that also cover the previously uncovered exception case, which brings coverage of the function to 100% and ever so slighly increases coverage of the overarching file.
timvandermeij
force-pushed
the
core-utils-test
branch
from
2dc955a to
67d591f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21547 +/- ##
=======================================
Coverage 89.72% 89.73%
=======================================
Files 262 262
Lines 66710 66710
=======================================
+ Hits 59856 59861 +5
+ Misses 6854 6849 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is mostly covered indirectly by higher-level tests, but unlike the other core utility functions it lacked dedicated unit tests. This commit implements unit tests for it that also cover the previously uncovered exception case, which brings coverage of the function to 100% and ever so slighly increases coverage of the overarching file.