Skip to content

Use cfg_aliases to reduce boilerplate#2644

Open
Felixoid wants to merge 5 commits intomozilla:mainfrom
Felixoid:cfg-aliases
Open

Use cfg_aliases to reduce boilerplate#2644
Felixoid wants to merge 5 commits intomozilla:mainfrom
Felixoid:cfg-aliases

Conversation

@Felixoid
Copy link
Copy Markdown
Contributor

cfg_aliases allows to define a long any(feature = "",....) only once and then reuse it.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 87.38739% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.92%. Comparing base (b81fdbb) to head (671ccc0).

Files with missing lines Patch % Lines
src/config.rs 81.25% 12 Missing ⚠️
src/cache/multilevel.rs 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2644      +/-   ##
==========================================
+ Coverage   73.58%   73.92%   +0.33%     
==========================================
  Files          70       71       +1     
  Lines       38220    40172    +1952     
==========================================
+ Hits        28125    29698    +1573     
- Misses      10095    10474     +379     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Felixoid
Copy link
Copy Markdown
Contributor Author

#2581 has 4 more places that would benefit from this patch.

@Felixoid Felixoid force-pushed the cfg-aliases branch 2 times, most recently from efe2feb to 41782cd Compare April 23, 2026 10:29
@Felixoid
Copy link
Copy Markdown
Contributor Author

The codecov issue is related to codecov/codecov-action#1940

@Felixoid Felixoid force-pushed the cfg-aliases branch 3 times, most recently from 640ece9 to ec40cec Compare April 23, 2026 14:33
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 23, 2026

Merging this PR will not alter performance

✅ 60 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing Felixoid:cfg-aliases (671ccc0) with main (b81fdbb)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants