feat: Make REQUEST_TIMEOUT_SECS and CONNECT configurable#2691
Open
nunokaeru wants to merge 1 commit intomozilla:mainfrom
Open
feat: Make REQUEST_TIMEOUT_SECS and CONNECT configurable#2691nunokaeru wants to merge 1 commit intomozilla:mainfrom
nunokaeru wants to merge 1 commit intomozilla:mainfrom
Conversation
AJIOB
reviewed
Apr 30, 2026
nunokaeru
force-pushed
the
request-config
branch
4 times, most recently
from
51e8aa0 to
a1aaa24
Compare
Some kernels can take upwards of 5 minutes to compile but 10 minutes might be too high of a timeout in the most common use cases. Add a runtime configuration option for both the Request and the Connect timeout.
AJIOB
approved these changes
May 2, 2026
Collaborator
|
please add a test to make sure we won't regress |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2691 +/- ##
=======================================
Coverage 74.27% 74.27%
=======================================
Files 70 70
Lines 39325 39337 +12
=======================================
+ Hits 29208 29218 +10
- Misses 10117 10119 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
Will do and fix clippy issues too, might take a while as I’m lacking free time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some kernels can take upwards of 5 minutes to compile but 10 minutes might be too high of a timeout in the most common use cases.
Add a runtime configuration option for both the Request and the Connect timeout.
Closes: #2276