feat: support S3 SSE-KMS#2770
Open
jpadilla wants to merge 2 commits into
Open
Conversation
jpadilla
force-pushed
the
feat/s3-sse-kms
branch
2 times, most recently
from
July 16, 2026 22:26
9e7ac56 to
57e9ccd
Compare
jpadilla
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2770 +/- ##
==========================================
- Coverage 74.18% 70.88% -3.31%
==========================================
Files 71 71
Lines 40505 40306 -199
==========================================
- Hits 30049 28571 -1478
- Misses 10456 11735 +1279 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
please run rustfmt |
Add two S3 config options alongside the existing SSE-S3 toggle: - server_side_encryption_aws_kms (SCCACHE_S3_SERVER_SIDE_ENCRYPTION_AWS_KMS) enables SSE-KMS with the AWS-managed key (aws/s3). - server_side_encryption_kms_key_id (SCCACHE_S3_SERVER_SIDE_ENCRYPTION_KMS_KEY_ID) enables SSE-KMS with a customer-managed KMS key. Resolution precedence in the S3 builder: customer-managed KMS key > AWS-managed KMS > SSE-S3. Existing server_side_encryption configs are unchanged. Signed-off-by: José Padilla <jose.padilla@okta.com>
jpadilla
force-pushed
the
feat/s3-sse-kms
branch
from
July 21, 2026 12:21
57e9ccd to
9a77055
Compare
Author
|
@sylvestre should be ready to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two S3 config options alongside the existing SSE-S3 toggle:
server_side_encryption_aws_kms(SCCACHE_S3_SERVER_SIDE_ENCRYPTION_AWS_KMS) enables SSE-KMS with the AWS-managed key (aws/s3).server_side_encryption_kms_key_id(SCCACHE_S3_SERVER_SIDE_ENCRYPTION_KMS_KEY_ID) enables SSE-KMS with a customer-managed KMS key.Resolution precedence in the S3 builder: customer-managed KMS key >
AWS-managed KMS > SSE-S3. Existing
server_side_encryptionconfigs are unchanged.