Simplify the code from pr #2761#2774
Open
sylvestre wants to merge 2 commits into
Open
Conversation
…arms Replace the hand-rolled `match ... => return Err(err)` arms in the reader and handler loops with `?`. The mpsc channel now carries a plain SccacheRequest (stream errors are unwrapped in the reader via `req?`), so the handler's outer Ok/Err match goes away and `.await??` propagates the join and call errors. No behavior change. Also document why `_handle` must stay bound: it is the AbortOnDropHandle that drives cancellation when the client disconnects.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2774 +/- ##
=======================================
Coverage 70.90% 70.91%
=======================================
Files 71 71
Lines 40393 40374 -19
=======================================
- Hits 28642 28630 -12
+ Misses 11751 11744 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Drop the extra `async move { ... }.await` wrapper (and its
#[allow(clippy::redundant_async_block)] and TODO) that was kept only to
minimize the whitespace diff against upstream/main, and de-indent the
task body one level. Purely a cleanup; no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see pr #2761