Expose remote cache read errors and fail on server disconnects#2779
Open
seungpyoson wants to merge 1 commit into
Open
Expose remote cache read errors and fail on server disconnects#2779seungpyoson wants to merge 1 commit into
seungpyoson wants to merge 1 commit into
Conversation
seungpyoson
force-pushed
the
agent/fail-closed-cache-errors
branch
from
July 24, 2026 08:11
e14c22c to
5abf492
Compare
seungpyoson
marked this pull request as ready for review
July 24, 2026 08:22
seungpyoson
force-pushed
the
agent/fail-closed-cache-errors
branch
from
July 24, 2026 08:38
5abf492 to
83b66fd
Compare
seungpyoson
force-pushed
the
agent/fail-closed-cache-errors
branch
from
July 24, 2026 08:59
83b66fd to
a35fe90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotFoundremote read failures through the existing cache-error statistics path instead of counting them as ordinary missesCompileStartedresponse I/O failures follow the documented default-fatal policy while preservingSCCACHE_IGNORE_SERVER_IO_ERROR=1Deliberately unchanged
Scope
One commit changes
src/cache/cache.rsandsrc/commands.rsonly. There are no documentation, protocol, cache-format, dependency, disk-cache, multi-level-cache, or client-side-storage changes. Existing documentation already describes the server-I/O policy.Validation
Focused regression tests cover unexpected direct remote read errors, default-fatal post-start disconnects, and the existing opt-in local fallback. Upstream CI and maintainer review remain required before merge.