chore: Remove unnecessary // eslint-disable comment for import/no-unresolved#3688
Open
PatrykKuniczak wants to merge 1 commit intomozilla:masterfrom
Open
Conversation
PatrykKuniczak
changed the title
import/no-unresolved// eslint-disable comment for import/no-unresolved
Contributor
Author
|
@Rob--W There's another problem with tests across PRs |
Member
|
This is merely a warning, but if not built (e.g. on a fresh checkout) this would be a linter warning. On the other hand, there are no CI failures without this linter suppression. @rpl thoughts on this one? |
Contributor
Author
|
@Rob--W Yeah indeed, there's no CI error, that's why i haven't closed it, after i opened it😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you'll want that change, i'll remove
// NOTE ...also