fix: Avoid autoreloading by Chrome-generated files#3696
Open
Rob--W wants to merge 1 commit intomozilla:masterfrom
Open
fix: Avoid autoreloading by Chrome-generated files#3696Rob--W wants to merge 1 commit intomozilla:masterfrom
Rob--W wants to merge 1 commit intomozilla:masterfrom
Conversation
d0656cb to
11a79fb
Compare
11a79fb to
50c2b2a
Compare
Member
Author
|
CI was repeatedly failing due to I identified the root cause, to be a watchpack bug, and created a PR to fix that: #3697. CI is currently red because #3697 is not included in the PR. Here is a fully green CI job for #3697 + this PR: https://app.circleci.com/pipelines/github/mozilla/web-ext/4894/workflows/871b8d37-b0ce-475a-9094-182c9c889cb0 |
Member
Author
|
While this PR works, I wonder whether I should have added the ignore patterns to web-ext/src/util/file-filter.js Lines 32 to 39 in 3b2a518 That is passed to the watcher at: web-ext/src/extension-runners/index.js Lines 199 to 206 in 3b2a518 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3468
Must be merged after #3697 to avoid test failures.