Skip to content

fix: Avoid auto-reload for recently created source directory #3697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rob--W wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −3
Open

fix: Avoid auto-reload for recently created source directory #3697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cmd/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,6 @@ export default async function run(
if (noReload) {
log.info('Automatic extension reloading has been disabled');
} else {
log.info('The extension will reload if any source file changes');

reloadStrategy({
extensionRunner,
sourceDir,
Expand All @@ -217,6 +215,8 @@ export default async function run(
ignoreFiles,
noInput,
});

log.info('The extension will reload if any source file changes');
}

return extensionRunner;
Expand Down
4 changes: 3 additions & 1 deletion src/watcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ export default function onSourceChange({
files: watchedFiles,
directories: watchedDirs,
missing: [],
startTime: Date.now(),
// startTime: Date.now(), is explicitly NOT set because it causes onChange
// to be emitted if the files were created shortly before now!
// See https://github.com/webpack/watchpack/issues/295
});

// TODO: support interrupting the watcher on Windows.
Expand Down