feat: Support multiple extensions in web-ext run#3700
Open
Rob--W wants to merge 1 commit intomozilla:masterfrom
Open
feat: Support multiple extensions in web-ext run#3700Rob--W wants to merge 1 commit intomozilla:masterfrom
Rob--W wants to merge 1 commit intomozilla:masterfrom
Conversation
Before this patch, `web-ext run` was equivalent to `web-ext run -s .` or `web-ext run --source-dir .` and did not support additional directories. This patch adds support for loading multiple source directories. Example of loading current directory plus another one: ``` web-ext run -s . -s path/to/another ``` This starts Firefox desktop with both extensions loaded. If any of their sources change, the extension will be updated in the browser. This functionality works for Firefox desktop, Firefox for Android, Chromium (the ChromiumExtensionRunner now supports reloading of individual extensions; previously it just reloaded "all" of them). The R reload shortcut reloads all extensions at once. The existing change detection logic automatically added the artifacts directory (`web-ext-artifacts`) to the ignores for watching purposes. This is not implemented for the additional source directories. Use `--ignore-files` if you want to ignore them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1107.
Before this patch,
web-ext runwas equivalent toweb-ext run -s .orweb-ext run --source-dir .and did not support additional directories. This patch adds support for loading multiple source directories.Example of loading current directory plus another one:
This starts Firefox desktop with both extensions loaded. If any of their sources change, the extension will be updated in the browser.
This functionality works for Firefox desktop, Firefox for Android, Chromium (the ChromiumExtensionRunner now supports reloading of individual extensions; previously it just reloaded "all" of them).
The R reload shortcut reloads all extensions at once.
The existing change detection logic automatically added the artifacts directory (
web-ext-artifacts) to the ignores for watching purposes. This is not implemented for the additional source directories. Use--ignore-filesif you want to ignore them.