Skip to content

Commit 33a4f53

Browse files
Mansi-mParticleMansi-mParticle
committed
Fix Lint error
1 parent 6d13045 commit 33a4f53

3 files changed

Lines changed: 52 additions & 24 deletions

File tree

‎build.gradle‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ apply plugin: 'com.mparticle.kit'
3636

3737
android {
3838
namespace 'com.mparticle.kits.responsys'
39+
buildFeatures {
40+
buildConfig = true
41+
}
3942
defaultConfig {
4043
minSdkVersion 16
4144
}

‎src/main/kotlin/com/mparticle/kits/ResponsysKit.kt‎

Lines changed: 44 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -8,24 +8,34 @@ import com.mparticle.MParticle.IdentityType
88
import com.mparticle.commerce.CommerceEvent
99
import com.mparticle.commerce.Product
1010
import com.mparticle.identity.MParticleUser
11-
import com.mparticle.kits.KitIntegration.*
11+
import com.mparticle.kits.FilteredIdentityApiRequest
12+
import com.mparticle.kits.KitIntegration.CommerceListener
13+
import com.mparticle.kits.KitIntegration.EventListener
14+
import com.mparticle.kits.KitIntegration.IdentityListener
15+
import com.mparticle.kits.KitIntegration.PushListener
16+
import com.mparticle.kits.ReportingMessage
1217
import com.pushio.manager.PIOLogger
1318
import com.pushio.manager.PushIOBroadcastReceiver
1419
import com.pushio.manager.PushIOManager
1520
import com.pushio.manager.exception.ValidationException
1621
import com.pushio.manager.preferences.PushIOPreference
1722
import java.math.BigDecimal
23+
import java.util.ArrayList
24+
import java.util.HashMap
1825

19-
class ResponsysKit : KitIntegration(), PushListener, KitIntegration.EventListener, CommerceListener,
26+
class ResponsysKit :
27+
KitIntegration(),
28+
PushListener,
29+
KitIntegration.EventListener,
30+
CommerceListener,
2031
IdentityListener {
21-
2232
private var mPushIOManager: PushIOManager? = null
2333

2434
override fun getInstance(): PushIOManager? = mPushIOManager
2535

2636
override fun onKitCreate(
2737
settings: Map<String, String>,
28-
context: Context
38+
context: Context,
2939
): List<ReportingMessage> {
3040
PIOLogger.d("Responsys Kit detected")
3141
PIOLogger.v("RK oKC")
@@ -63,7 +73,7 @@ class ResponsysKit : KitIntegration(), PushListener, KitIntegration.EventListene
6373
bigDecimal: BigDecimal,
6474
bigDecimal1: BigDecimal,
6575
s: String,
66-
map: Map<String, String>
76+
map: Map<String, String>,
6777
): List<ReportingMessage> = emptyList()
6878

6979
override fun logEvent(commerceEvent: CommerceEvent): List<ReportingMessage>? {
@@ -94,7 +104,8 @@ class ResponsysKit : KitIntegration(), PushListener, KitIntegration.EventListene
94104
if (productAction.equals(Product.PURCHASE, true)) {
95105
mPushIOManager?.trackEngagement(
96106
PushIOManager.PUSHIO_ENGAGEMENT_METRIC_PURCHASE,
97-
customProperties, null
107+
customProperties,
108+
null,
98109
)
99110
}
100111
}
@@ -108,12 +119,15 @@ class ResponsysKit : KitIntegration(), PushListener, KitIntegration.EventListene
108119

109120
override fun leaveBreadcrumb(s: String): List<ReportingMessage> = emptyList()
110121

111-
override fun logError(s: String, map: Map<String, String>): List<ReportingMessage> = emptyList()
122+
override fun logError(
123+
s: String,
124+
map: Map<String, String>,
125+
): List<ReportingMessage> = emptyList()
112126

113127
override fun logException(
114128
e: Exception,
115129
map: Map<String, String>,
116-
s: String
130+
s: String,
117131
): List<ReportingMessage> = emptyList()
118132

119133
override fun logEvent(mpEvent: MPEvent): List<ReportingMessage>? {
@@ -135,7 +149,7 @@ class ResponsysKit : KitIntegration(), PushListener, KitIntegration.EventListene
135149
it.declarePreference(
136150
key,
137151
key,
138-
PushIOPreference.Type.STRING
152+
PushIOPreference.Type.STRING,
139153
)
140154
it.setPreference(key, value)
141155
} catch (e: ValidationException) {
@@ -154,21 +168,29 @@ class ResponsysKit : KitIntegration(), PushListener, KitIntegration.EventListene
154168
return if (reportingMessages.isEmpty()) null else reportingMessages
155169
}
156170

157-
override fun logScreen(s: String, map: Map<String, String>): List<ReportingMessage> =
158-
emptyList()
171+
override fun logScreen(
172+
s: String,
173+
map: Map<String, String>,
174+
): List<ReportingMessage> = emptyList()
159175

160176
override fun willHandlePushMessage(intent: Intent): Boolean {
161177
PIOLogger.v("RK wHPM")
162178
return isResponsysPush(intent)
163179
}
164180

165-
override fun onPushMessageReceived(context: Context, intent: Intent) {
181+
override fun onPushMessageReceived(
182+
context: Context,
183+
intent: Intent,
184+
) {
166185
PIOLogger.v("RK oPMR")
167186
val newIntent = Intent(intent)
168187
PushIOBroadcastReceiver().onReceive(getContext(), newIntent)
169188
}
170189

171-
override fun onPushRegistration(instanceId: String, senderId: String): Boolean {
190+
override fun onPushRegistration(
191+
instanceId: String,
192+
senderId: String,
193+
): Boolean {
172194
PIOLogger.v("RK oPR Instance ID: $instanceId, Sender ID: $senderId")
173195
mPushIOManager?.let {
174196
it.setDeviceToken(instanceId)
@@ -179,29 +201,29 @@ class ResponsysKit : KitIntegration(), PushListener, KitIntegration.EventListene
179201

180202
override fun onIdentifyCompleted(
181203
mParticleUser: MParticleUser,
182-
filteredIdentityApiRequest: FilteredIdentityApiRequest
204+
filteredIdentityApiRequest: FilteredIdentityApiRequest,
183205
) {
184206
}
185207

186208
override fun onLoginCompleted(
187209
mParticleUser: MParticleUser,
188-
filteredIdentityApiRequest: FilteredIdentityApiRequest
210+
filteredIdentityApiRequest: FilteredIdentityApiRequest,
189211
) {
190212
PIOLogger.v("RK oLiC")
191213
registerUserId(mParticleUser)
192214
}
193215

194216
override fun onLogoutCompleted(
195217
mParticleUser: MParticleUser,
196-
filteredIdentityApiRequest: FilteredIdentityApiRequest
218+
filteredIdentityApiRequest: FilteredIdentityApiRequest,
197219
) {
198220
PIOLogger.v("RK oLoC")
199221
mPushIOManager?.unregisterUserId()
200222
}
201223

202224
override fun onModifyCompleted(
203225
mParticleUser: MParticleUser,
204-
filteredIdentityApiRequest: FilteredIdentityApiRequest
226+
filteredIdentityApiRequest: FilteredIdentityApiRequest,
205227
) {
206228
}
207229

@@ -224,10 +246,10 @@ class ResponsysKit : KitIntegration(), PushListener, KitIntegration.EventListene
224246
return userId
225247
}
226248

227-
private fun isResponsysPush(intent: Intent?): Boolean {
228-
return intent != null && intent.hasExtra("ei") &&
229-
!KitUtils.isEmpty(intent.getStringExtra("ei"))
230-
}
249+
private fun isResponsysPush(intent: Intent?): Boolean =
250+
intent != null &&
251+
intent.hasExtra("ei") &&
252+
!KitUtils.isEmpty(intent.getStringExtra("ei"))
231253

232254
private fun processCustomFlags(mpEvent: MPEvent): MutableList<ReportingMessage> {
233255
val reportingMessages: MutableList<ReportingMessage> = ArrayList()
@@ -248,7 +270,7 @@ class ResponsysKit : KitIntegration(), PushListener, KitIntegration.EventListene
248270
PIOLogger.e("Invalid engagement type")
249271
PIOLogger.e(
250272
"Supported engagement types can be accessed from PushIOManager and are of type: " +
251-
"PushIOManager.PUSHIO_ENGAGEMENT_METRIC_***"
273+
"PushIOManager.PUSHIO_ENGAGEMENT_METRIC_***",
252274
)
253275
}
254276
}

src/test/kotlin/com/mparticle/kits/ResponsysKitTest.kt renamed to src/test/kotlin/com/mparticle/kits/KitTests.kt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@ package com.mparticle.kits
22

33
import android.content.Context
44
import com.mparticle.MParticleOptions
5+
import com.mparticle.kits.KitIntegration
6+
import com.mparticle.kits.KitIntegrationFactory
57
import org.junit.Assert
68
import org.junit.Test
79
import org.mockito.Mockito
10+
import java.util.HashMap
811

912
class KitTests {
1013
private val kit: KitIntegration
@@ -27,7 +30,7 @@ class KitTests {
2730
var e: Exception? = null
2831
try {
2932
val kit = kit
30-
val settings= HashMap<String,String>()
33+
val settings = HashMap<String, String>()
3134
settings["fake setting"] = "fake"
3235
kit.onKitCreate(settings, Mockito.mock(Context::class.java))
3336
} catch (ex: Exception) {
@@ -50,4 +53,4 @@ class KitTests {
5053
}
5154
Assert.fail("$className not found as a known integration.")
5255
}
53-
}
56+
}

0 commit comments

Comments
 (0)