Address review comments and updated test cases

Author: Mansi-mParticle

src/main/kotlin/com/mparticle/kits/RoktKit.kt

@@ -383,28 +383,28 @@ class RoktKit :
     }
 
     private fun getStringForIdentity(identityType: IdentityType): String = when (identityType) {
-        IdentityType.Other -> "Other"
-        IdentityType.CustomerId -> "CustomerId"
-        IdentityType.Facebook -> "Facebook"
-        IdentityType.Twitter -> "Twitter"
-        IdentityType.Google -> "Google"
-        IdentityType.Microsoft -> "Microsoft"
-        IdentityType.Yahoo -> "Yahoo"
-        IdentityType.Email -> "Email"
-        IdentityType.Alias -> "Alias"
-        IdentityType.FacebookCustomAudienceId -> "FacebookCustomAudienceId"
-        IdentityType.Other2 -> "Other2"
-        IdentityType.Other3 -> "Other3"
-        IdentityType.Other4 -> "Other4"
-        IdentityType.Other5 -> "Other5"
-        IdentityType.Other6 -> "Other6"
-        IdentityType.Other7 -> "Other7"
-        IdentityType.Other8 -> "Other8"
-        IdentityType.Other9 -> "Other9"
-        IdentityType.Other10 -> "Other10"
-        IdentityType.MobileNumber -> "MobileNumber"
-        IdentityType.PhoneNumber2 -> "PhoneNumber2"
-        IdentityType.PhoneNumber3 -> "PhoneNumber3"
+        IdentityType.Other -> "other"
+        IdentityType.CustomerId -> "customerid"
+        IdentityType.Facebook -> "facebook"
+        IdentityType.Twitter -> "twitter"
+        IdentityType.Google -> "google"
+        IdentityType.Microsoft -> "microsoft"
+        IdentityType.Yahoo -> "yahoo"
+        IdentityType.Email -> "email"
+        IdentityType.Alias -> "alias"
+        IdentityType.FacebookCustomAudienceId -> "facebookcustomaudienceid"
+        IdentityType.Other2 -> "other2"
+        IdentityType.Other3 -> "other3"
+        IdentityType.Other4 -> "other4"
+        IdentityType.Other5 -> "other5"
+        IdentityType.Other6 -> "other6"
+        IdentityType.Other7 -> "other7"
+        IdentityType.Other8 -> "other8"
+        IdentityType.Other9 -> "other9"
+        IdentityType.Other10 -> "other10"
+        IdentityType.MobileNumber -> "mobilenumber"
+        IdentityType.PhoneNumber2 -> "phonenumber2"
+        IdentityType.PhoneNumber3 -> "phonenumber3"
         else -> ""
     }
 

src/test/kotlin/com/mparticle/kits/RoktKitTests.kt

@@ -300,7 +300,7 @@ class RoktKitTests {
     }
 
     @Test
-    fun test_addIdentityAttributes_When_userIdentities_UNASSIGNED_map_To_Identity() {
+    fun test_addIdentityAttributes_When_userIdentities_Unknown_map_To_Identity() {
         val mockFilterUser = mock(FilteredMParticleUser::class.java)
         val userIdentities = HashMap<IdentityType, String>()
         userIdentities.put(IdentityType.Email, "TestEmail@gamil.com")
@@ -313,7 +313,7 @@ class RoktKitTests {
         )
         val hashedField = RoktKit::class.java.getDeclaredField("hashedEmailUserIdentityType")
         hashedField.isAccessible = true
-        hashedField.set(roktKit, "UNASSIGNED")
+        hashedField.set(roktKit, "Unknown")
         val method: Method = RoktKit::class.java.getDeclaredMethod(
             "addIdentityAttributes",
             Map::class.java,
@@ -326,8 +326,8 @@ class RoktKitTests {
         assertTrue(result.containsKey("key1"))
         assertTrue(result.containsKey("key2"))
         assertTrue(result.containsKey("key3"))
-        assertTrue(result.containsKey("Email"))
-        assertTrue(result.containsKey("Other"))
+        assertTrue(result.containsKey("email"))
+        assertTrue(result.containsKey("other"))
     }
 
     @Test