Skip to content

Commit b5db14b

Browse files
committed
Refactor and rename the execute method used in core->kit communication to selectPlacements
1 parent eeb764a commit b5db14b

3 files changed

Lines changed: 9 additions & 10 deletions

File tree

src/main/kotlin/com/mparticle/kits/RoktKit.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ class RoktKit :
167167
For more details, visit the official documentation:
168168
https://docs.rokt.com/developers/integration-guides/android/how-to/adding-a-placement/
169169
*/
170-
override fun execute(
170+
override fun selectPlacements(
171171
viewName: String,
172172
attributes: Map<String, String>,
173173
mpRoktEventCallback: MpRoktEventCallback?,

src/main/kotlin/com/mparticle/kits/RoktLayout.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import com.mparticle.MpRoktEventCallback
99
import com.mparticle.rokt.PlacementOptions
1010
import com.mparticle.rokt.RoktConfig
1111
import com.rokt.roktsdk.Rokt
12-
import com.rokt.roktsdk.RoktLayout
1312

1413
@Composable
1514
@Suppress("FunctionName")
@@ -43,7 +42,7 @@ fun RoktLayout(
4342
}
4443

4544
resultMapState.value?.let { resultMap ->
46-
RoktLayout(
45+
com.rokt.roktsdk.RoktLayout(
4746
sdkTriggered, identifier, modifier, resultMap.attributes, location,
4847
onLoad = { resultMap.callback.onLoad() },
4948
onShouldShowLoadingIndicator = { resultMap.callback.onShouldShowLoadingIndicator() },

src/test/kotlin/com/mparticle/kits/RoktKitTests.kt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ class RoktKitTests {
156156

157157
// Act
158158
val inputAttributes: Map<String, String> = mapOf("initial_attr" to "initial_value")
159-
roktKit.execute(
159+
roktKit.selectPlacements(
160160
viewName = "test_view",
161161
attributes = inputAttributes,
162162
mpRoktEventCallback = null,
@@ -213,7 +213,7 @@ class RoktKitTests {
213213
roktKit.configuration = MockKitConfiguration.createKitConfiguration(JSONObject().put("hs", JSONObject()))
214214

215215
// Act
216-
roktKit.execute(
216+
roktKit.selectPlacements(
217217
viewName = "test_view",
218218
attributes = emptyMap(),
219219
mpRoktEventCallback = null,
@@ -262,7 +262,7 @@ class RoktKitTests {
262262
roktKit.configuration = MockKitConfiguration.createKitConfiguration(JSONObject().put("hs", JSONObject()))
263263

264264
// Act
265-
roktKit.execute(
265+
roktKit.selectPlacements(
266266
viewName = "test_view",
267267
attributes = emptyMap(),
268268
mpRoktEventCallback = null,
@@ -311,7 +311,7 @@ class RoktKitTests {
311311
roktKit.configuration = MockKitConfiguration.createKitConfiguration(JSONObject().put("hs", JSONObject()))
312312

313313
// Act
314-
roktKit.execute(
314+
roktKit.selectPlacements(
315315
viewName = "test_view",
316316
attributes = emptyMap(),
317317
mpRoktEventCallback = null,
@@ -378,7 +378,7 @@ class RoktKitTests {
378378
"ShouldFilter" to "testData",
379379
)
380380
// Act
381-
roktKit.execute(
381+
roktKit.selectPlacements(
382382
viewName = "test",
383383
attributes = inputAttributes,
384384
mpRoktEventCallback = null,
@@ -453,7 +453,7 @@ class RoktKitTests {
453453
"ShouldFilter" to "testData",
454454
)
455455
// Act
456-
roktKit.execute(
456+
roktKit.selectPlacements(
457457
viewName = "test",
458458
attributes = inputAttributes,
459459
mpRoktEventCallback = null,
@@ -1354,7 +1354,7 @@ class RoktKitTests {
13541354
// Set MParticle instance to null
13551355
MParticle.setInstance(null)
13561356

1357-
roktKit.execute(
1357+
roktKit.selectPlacements(
13581358
viewName = "test_view",
13591359
attributes = testAttributes,
13601360
mpRoktEventCallback = null,

0 commit comments

Comments
 (0)