Skip to content

Commit ba9350f

Browse files
committed
Update Rokt SDK and add PlacementOptions with timestamps
1 parent e02c223 commit ba9350f

5 files changed

Lines changed: 13 additions & 7 deletions

File tree

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ dependencies {
7575
implementation 'androidx.annotation:annotation:1.5.0'
7676
implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4'
7777
implementation 'androidx.compose.runtime:runtime'
78-
api 'com.rokt:roktsdk:4.13.0'
78+
api 'com.rokt:roktsdk:4.13.1'
7979

8080
testImplementation files('libs/java-json.jar')
8181
testImplementation 'com.squareup.assertj:assertj-android:1.2.0'

src/main/kotlin/com/mparticle/kits/RoktConfigExtensions.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ fun RoktConfig.toRoktSdkConfig(): RoktSdkConfig {
3232
return builder.build()
3333
}
3434

35-
// TODO: Update the mapping
36-
/*fun PlacementOptions.toRoktSdkPlacementOptions(): com.rokt.roktsdk.PlacementOptions = com.rokt.roktsdk.PlacementOptions(
35+
fun PlacementOptions.toRoktSdkPlacementOptions(): com.rokt.roktsdk.PlacementOptions = com.rokt.roktsdk.PlacementOptions(
3736
jointSdkSelectPlacements = this.jointSdkSelectPlacements,
3837
dynamicPerformanceMarkers = this.dynamicPerformanceMarkers,
39-
)*/
38+
)

src/main/kotlin/com/mparticle/kits/RoktKit.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,6 @@ class RoktKit :
200200
this.mpRoktEventCallback = mpRoktEventCallback
201201
val finalAttributes = prepareFinalAttributes(filterUser, attributes)
202202
val roktConfig = mpRoktConfig?.toRoktSdkConfig()
203-
// TODO: propagate the `placementOptions` to Rokt SDK after the API changes are available
204203
Rokt.execute(
205204
viewName,
206205
finalAttributes,
@@ -209,6 +208,7 @@ class RoktKit :
209208
placeholders.takeIf { it?.isNotEmpty() == true },
210209
fontTypefaces.takeIf { it?.isNotEmpty() == true },
211210
roktConfig,
211+
placementOptions?.toRoktSdkPlacementOptions(),
212212
)
213213
}
214214

@@ -351,7 +351,7 @@ class RoktKit :
351351
) {
352352
val instance = MParticle.getInstance()
353353
deferredAttributes = CompletableDeferred()
354-
instance?.Internal()?.kitManager?.prepareAttributesAsync(attributes)
354+
instance?.Internal()?.kitManager?.roktKitApi?.prepareAttributesAsync(attributes)
355355
this.mpRoktEventCallback = mpRoktEventCallback
356356
CoroutineScope(Dispatchers.Default).launch {
357357
val resultAttributes = deferredAttributes!!.await()

src/main/kotlin/com/mparticle/kits/RoktLayout.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,14 @@ fun RoktLayout(
4343
}
4444

4545
resultMapState.value?.let { resultMap ->
46-
// TODO: Propagate the `placementOptions` to Rokt SDK after the API changes are available
4746
RoktLayout(
4847
sdkTriggered, identifier, modifier, resultMap.attributes, location,
4948
onLoad = { resultMap.callback.onLoad() },
5049
onShouldShowLoadingIndicator = { resultMap.callback.onShouldShowLoadingIndicator() },
5150
onShouldHideLoadingIndicator = { resultMap.callback.onShouldHideLoadingIndicator() },
5251
onUnload = { reason -> resultMap.callback.onUnload(reason) },
5352
config = config?.toRoktSdkConfig(),
53+
placementOptions = placementOptions?.toRoktSdkPlacementOptions(),
5454
)
5555
}
5656
}

src/test/kotlin/com/mparticle/kits/RoktKitTests.kt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ class RoktKitTests {
164164
fontTypefaces = null,
165165
filterUser = mockFilterUser,
166166
mpRoktConfig = null,
167+
placementOptions = null,
167168
)
168169

169170
// Assert
@@ -220,6 +221,7 @@ class RoktKitTests {
220221
fontTypefaces = null,
221222
filterUser = mockFilterUser,
222223
mpRoktConfig = null,
224+
placementOptions = null,
223225
)
224226

225227
// Assert
@@ -268,6 +270,7 @@ class RoktKitTests {
268270
fontTypefaces = null,
269271
filterUser = mockFilterUser,
270272
mpRoktConfig = null,
273+
placementOptions = null,
271274
)
272275

273276
// Assert
@@ -316,6 +319,7 @@ class RoktKitTests {
316319
fontTypefaces = null,
317320
filterUser = mockFilterUser,
318321
mpRoktConfig = null,
322+
placementOptions = null,
319323
)
320324

321325
// Assert
@@ -382,6 +386,7 @@ class RoktKitTests {
382386
fontTypefaces = null,
383387
filterUser = mockFilterUser,
384388
mpRoktConfig = null,
389+
placementOptions = null,
385390
)
386391

387392
// Assert
@@ -456,6 +461,7 @@ class RoktKitTests {
456461
fontTypefaces = null,
457462
filterUser = mockFilterUser,
458463
mpRoktConfig = null,
464+
placementOptions = null,
459465
)
460466

461467
// Assert
@@ -1356,6 +1362,7 @@ class RoktKitTests {
13561362
fontTypefaces = null,
13571363
filterUser = mockFilterUser,
13581364
mpRoktConfig = null,
1365+
placementOptions = null,
13591366
)
13601367

13611368
verify(exactly = 1) {

0 commit comments

Comments
 (0)