Skip to content

fix: Refactor execute method signature#28

Merged
Mansi-mParticle merged 2 commits into
developmentfrom
fix/change-method-signature
May 30, 2025
Merged

fix: Refactor execute method signature#28
Mansi-mParticle merged 2 commits into
developmentfrom
fix/change-method-signature

Conversation

@Mansi-mParticle

Copy link
Copy Markdown
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Made 'attributes' parameter non-nullable to ensure a valid map is always passed and Made 'mpRoktEventCallback' parameter nullable to allow optional usage

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle requested a review from rmi22186 May 30, 2025 19:52
@Mansi-mParticle Mansi-mParticle merged commit 39c40aa into development May 30, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants