Skip to content

fix: correct rendering issue with Rokt placement holder#30

Merged
Mansi-mParticle merged 2 commits into
developmentfrom
fix/rokt-placement-holder-issue
Jun 9, 2025
Merged

fix: correct rendering issue with Rokt placement holder#30
Mansi-mParticle merged 2 commits into
developmentfrom
fix/rokt-placement-holder-issue

Conversation

@Mansi-mParticle

Copy link
Copy Markdown
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • This PR addresses and fixes the issue with the Rokt placement holder not rendering correctly. and Refactored code for better readability and efficiency.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested in the QA environment and US2 using the sample app.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Maybe a test case that would have caught that issue you fixed with line 144?

@Mansi-mParticle Mansi-mParticle merged commit eaf7e0e into development Jun 9, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants