feat: Add RoktConfig support#32
Conversation
Mansi-mParticle
requested review from
BrandonStalnaker,
alexs-mparticle and
rmi22186
| fontTypefaces: MutableMap<String, WeakReference<Typeface>>?, | ||
| filterUser: FilteredMParticleUser? | ||
| filterUser: FilteredMParticleUser?, | ||
| mpRoktConfig: RoktConfig? |
There was a problem hiding this comment.
| mpRoktConfig: RoktConfig? | |
| mpRoktConfig: RoktConfig?, |
Lint rules to add these automatically would be nice
There was a problem hiding this comment.
KtLint currently isn't working in the repo from what I can tell. Bumping to version 12.3.0 of the plugin used fixes the issue but there are around 50 issues flagged
There was a problem hiding this comment.
I made this ticket to update KTKLint. We can prioritize it in the future for someone. It may make sense for right after or before the release once the purchaseFinalized API gets in bc I think that's the last one we need for release.
| ) | ||
| } | ||
|
|
||
| public fun mapToRoktConfig(config: RoktConfig): com.rokt.roktsdk.RoktConfig { |
There was a problem hiding this comment.
@Mansi-mParticle I know it's merged already but wondering if this really should be public?
There was a problem hiding this comment.
It shouldn't be public. I just made it public for testing and will change it back.
5 participants
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)