Skip to content

chore: Add PR notification#50

Merged
jamesnrokt merged 2 commits into
developmentfrom
chore/pr-notification
Jul 15, 2025
Merged

chore: Add PR notification#50
jamesnrokt merged 2 commits into
developmentfrom
chore/pr-notification

Conversation

@jamesnrokt

Copy link
Copy Markdown
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Add PR notification

Testing Plan

  • N/A

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

  • N/A

Copilot AI review requested due to automatic review settings July 14, 2025 10:24
@jamesnrokt jamesnrokt requested a review from a team as a code owner July 14, 2025 10:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new GitHub Actions job to notify a Google Chat channel whenever a pull request is opened (and not in draft state).

  • Introduce a pr-notify job that runs after pr-check on non-draft PR open events.
  • Configure the job to call an external workflow for sending a GChat notification using a stored webhook secret.
Comments suppressed due to low confidence (3)

.github/workflows/pull-request.yml:15

  • Verify that the pr-check job is defined earlier in this workflow and the job key matches exactly, so the needs reference resolves correctly.
      - pr-check

.github/workflows/pull-request.yml:10

  • [nitpick] Consider renaming the job key from pr-notify to notify-gchat (or similar) to match kebab-case conventions and align with the descriptive name field.
  pr-notify:

.github/workflows/pull-request.yml:19

  • [nitpick] Add a short comment above this section to document the expected format and purpose of the GCHAT_PRS_WEBHOOK secret for better maintainability.
      gchat_webhook: ${{ secrets.GCHAT_PRS_WEBHOOK }}

thomson-t
thomson-t previously approved these changes Jul 15, 2025
@jamesnrokt jamesnrokt merged commit 382e74c into development Jul 15, 2025
17 checks passed
@jamesnrokt jamesnrokt deleted the chore/pr-notification branch July 15, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants