chore: Add PR notification#50
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a new GitHub Actions job to notify a Google Chat channel whenever a pull request is opened (and not in draft state).
- Introduce a
pr-notifyjob that runs afterpr-checkon non-draft PR open events. - Configure the job to call an external workflow for sending a GChat notification using a stored webhook secret.
Comments suppressed due to low confidence (3)
.github/workflows/pull-request.yml:15
- Verify that the
pr-checkjob is defined earlier in this workflow and the job key matches exactly, so theneedsreference resolves correctly.
- pr-check
.github/workflows/pull-request.yml:10
- [nitpick] Consider renaming the job key from
pr-notifytonotify-gchat(or similar) to match kebab-case conventions and align with the descriptivenamefield.
pr-notify:
.github/workflows/pull-request.yml:19
- [nitpick] Add a short comment above this section to document the expected format and purpose of the
GCHAT_PRS_WEBHOOKsecret for better maintainability.
gchat_webhook: ${{ secrets.GCHAT_PRS_WEBHOOK }}
thomson-t
previously approved these changes
Jul 15, 2025
thomson-t
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)