feat: Handle emailsha256 and other before sending attributes to Rokt Kit#51
Merged
Mansi-mParticle merged 8 commits intoAug 1, 2025
Merged
Conversation
rmi22186
requested changes
Jul 29, 2025
rmi22186
reviewed
Jul 29, 2025
rmi22186
requested changes
Jul 29, 2025
rmi22186
reviewed
Jul 30, 2025
rmi22186
left a comment
Collaborator
There was a problem hiding this comment.
looks good...how about some tests that cover the following:
- If
emailidentity exists on the user, andemailsha256attribute is passed toselectPlacements, do not sendemailattribute to theselectPlacementscall. - if
emailidentity andotheridentity exist on the user, only passemailsha256attribute with the value fromotheridentity
I think these would go in the kit, not core
BrandonStalnaker
requested changes
Jul 31, 2025
BrandonStalnaker
left a comment
Collaborator
There was a problem hiding this comment.
Update your addIdentityAttributes method to add the other identity as the "emailsha256" key instead. That way you don't overwrite the other attribute if its passed in.
BrandonStalnaker
requested changes
Jul 31, 2025
BrandonStalnaker
left a comment
Collaborator
There was a problem hiding this comment.
Just a couple minor things
BrandonStalnaker
approved these changes
Jul 31, 2025
rmi22186
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
If emailsha256 is present, remove both email and other from the attributes.
If other is present (and emailsha256 is not), map other to emailsha256, then remove both email and other.
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)