Skip to content

feat: Handle emailsha256 and other before sending attributes to Rokt Kit #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mansi-mParticle merged 8 commits into from
Aug 1, 2025
Merged

feat: Handle emailsha256 and other before sending attributes to Rokt Kit #51

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2bf3a3e
feat: Handle emailsha256 and other before sending attributes to Rokt Kit
Mansi-mParticle Jul 28, 2025
6fb67c6
Fix key capitalization to match conventions used across platforms
Mansi-mParticle Jul 28, 2025
16143c1
Fix case sensitivity issues in attribute key
Mansi-mParticle Jul 29, 2025
5db8833
Address review comments
Mansi-mParticle Jul 29, 2025
b755844
updated logic accoring to requirement update
Mansi-mParticle Jul 30, 2025
c16329f
Updated logic and added test cases
Mansi-mParticle Jul 31, 2025
3bc261a
update logic for other identity and add test cases
Mansi-mParticle Jul 31, 2025
2a60376
Address review comments
Mansi-mParticle Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions src/main/kotlin/com/mparticle/kits/RoktKit.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import android.content.pm.PackageManager
import android.graphics.Typeface
import android.os.Build
import com.mparticle.BuildConfig
import com.mparticle.MParticle
import com.mparticle.MParticle.IdentityType
import com.mparticle.MpRoktEventCallback
import com.mparticle.UnloadReasons
Expand Down Expand Up @@ -188,7 +189,7 @@ class RoktKit : KitIntegration(), CommerceListener, IdentityListener, RoktListen
}?.toMap()

this.mpRoktEventCallback = mpRoktEventCallback
val finalAttributes: HashMap<String, String> = HashMap<String, String>()
val finalAttributes = mutableMapOf<String, String>()
filterUser?.userAttributes?.let { userAttrs ->
for ((key, value) in userAttrs) {
finalAttributes[key] = value.toString()
Expand All @@ -199,13 +200,14 @@ class RoktKit : KitIntegration(), CommerceListener, IdentityListener, RoktListen
finalAttributes[MPID] = mpid
} ?: Logger.warning("RoktKit: No user ID available for placement")

addIdentityAttributes(finalAttributes, filterUser)
//addIdentityAttributes(finalAttributes, filterUser)
Comment thread
Mansi-mParticle marked this conversation as resolved.
Outdated


val SANDBOX_MODE_ROKT: String = "sandbox"
attributes?.get(SANDBOX_MODE_ROKT)?.let { value ->
finalAttributes.put(SANDBOX_MODE_ROKT, value)
}
verifyHashedEmail(finalAttributes)
val roktConfig = mpRoktConfig?.let { mapToRoktConfig(it) }
Rokt.execute(
viewName,
Expand Down Expand Up @@ -318,6 +320,32 @@ class RoktKit : KitIntegration(), CommerceListener, IdentityListener, RoktListen
}
}

private fun verifyHashedEmail(attributes: MutableMap<String, String>?) {
if (attributes == null) return

val emailKey = "Email"
val otherKey = "Other"
Comment thread
Mansi-mParticle marked this conversation as resolved.
Outdated
val emailShaKey = "emailsha256"

val emailSha = attributes[emailShaKey]
val otherValue = attributes[otherKey]

when {
!emailSha.isNullOrEmpty() -> {
attributes.remove(emailKey)
attributes.remove(otherKey)
}

!otherValue.isNullOrEmpty() -> {
Comment thread
Mansi-mParticle marked this conversation as resolved.
Outdated
attributes.remove(emailKey)
attributes[emailShaKey] = otherValue
attributes.remove(otherKey)
}

// else do nothing
}
}

private fun getStringForIdentity(identityType: IdentityType): String {
return when (identityType) {
IdentityType.Other -> "other"
Expand Down
Loading