Skip to content

feat: Map selected identity to emailsha256#58

Merged
Mansi-mParticle merged 5 commits into
developmentfrom
SQDSDKS-7633-Map-identity-to-emailsha256
Sep 23, 2025
Merged

feat: Map selected identity to emailsha256#58
Mansi-mParticle merged 5 commits into
developmentfrom
SQDSDKS-7633-Map-identity-to-emailsha256

Conversation

@Mansi-mParticle

@Mansi-mParticle Mansi-mParticle commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Updated the logic to use the emailsha256 key and match the Identity enum value with the Android core.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample app and Added unit test cases

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle requested a review from a team as a code owner August 19, 2025 18:56
@Mansi-mParticle Mansi-mParticle force-pushed the SQDSDKS-7633-Map-identity-to-emailsha256 branch 2 times, most recently from 357b352 to 9b82749 Compare August 22, 2025 18:37
BrandonStalnaker
BrandonStalnaker previously approved these changes Aug 27, 2025
View reviewed changes

@BrandonStalnaker BrandonStalnaker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rmi22186
rmi22186 reviewed Aug 28, 2025
View reviewed changes
Comment thread src/test/kotlin/com/mparticle/kits/RoktKitTests.kt Outdated
rmi22186
rmi22186 reviewed Aug 28, 2025
View reviewed changes
Comment thread src/main/kotlin/com/mparticle/kits/RoktKit.kt Outdated
@Mansi-mParticle Mansi-mParticle changed the title feat: Map selected identity to feat: Map selected identity to emailsha256 Sep 22, 2025
@Mansi-mParticle Mansi-mParticle changed the title feat: Map selected identity to emailsha256 feat: Map selected identity to emailsha256 Sep 22, 2025
@Mansi-mParticle Mansi-mParticle force-pushed the SQDSDKS-7633-Map-identity-to-emailsha256 branch from c670d88 to 0d137b1 Compare September 22, 2025 17:01
@Mansi-mParticle Mansi-mParticle merged commit 29ee4a3 into development Sep 23, 2025
16 of 17 checks passed
@Mansi-mParticle Mansi-mParticle deleted the SQDSDKS-7633-Map-identity-to-emailsha256 branch September 23, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

@BrandonStalnaker BrandonStalnaker BrandonStalnaker left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mansi-mParticle @rmi22186 @BrandonStalnaker