Adding extra check to avoid crash when anonymous users return an NSNull email (#72)

arctouch-jagnidasa · Jagni Dasa · web-flow · commit 3a7fb072a4a4 · 2023-05-16T09:28:41.000-05:00
Co-authored-by: Jagni Dasa &lt;Jagni.Dasa.-ND@disney.com&gt;
diff --git a/Sources/mParticle-Appboy/MPKitAppboy.m b/Sources/mParticle-Appboy/MPKitAppboy.m
@@ -781,7 +781,7 @@ - (nonnull MPKitExecStatus *)updateUser:(FilteredMParticleUser *)user request:(F
             }
         }
         
-        if (userId) {
+        if (userId && ![userId isKindOfClass: [NSNull class]]) {
             void (^changeUser)(void) = ^ {
                 [self->appboyInstance changeUser:userId];
             };
@@ -849,7 +849,7 @@ - (nonnull MPKitExecStatus *)updateUser:(FilteredMParticleUser *)user request:(F
             }
         }
         
-        if (userEmail) {
+        if (userEmail && ![userEmail isKindOfClass: [NSNull class]]) {
             [appboyInstance.user setEmail:userEmail];
             execStatus = [[MPKitExecStatus alloc] initWithSDKCode:@(MPKitInstanceAppboy) returnCode:MPKitReturnCodeSuccess];
         }

Original file line number	Diff line number	Diff line change
`@@ -781,7 +781,7 @@ - (nonnull MPKitExecStatus )updateUser:(FilteredMParticleUser )user request:(F`
`781`	`781`	`}`
`782`	`782`	`}`
`783`	`783`
`784`		`- if (userId) {`
	`784`	`+ if (userId && ![userId isKindOfClass: [NSNull class]]) {`
`785`	`785`	`void (^changeUser)(void) = ^ {`
`786`	`786`	`[self->appboyInstance changeUser:userId];`
`787`	`787`	`};`
`@@ -849,7 +849,7 @@ - (nonnull MPKitExecStatus )updateUser:(FilteredMParticleUser )user request:(F`
`849`	`849`	`}`
`850`	`850`	`}`
`851`	`851`
`852`		`- if (userEmail) {`
	`852`	`+ if (userEmail && ![userEmail isKindOfClass: [NSNull class]]) {`
`853`	`853`	`[appboyInstance.user setEmail:userEmail];`
`854`	`854`	`execStatus = [[MPKitExecStatus alloc] initWithSDKCode:@(MPKitInstanceAppboy) returnCode:MPKitReturnCodeSuccess];`
`855`	`855`	`}`