Skip to content

Commit 8c29f19

Browse files
authored
feat: Add Rokt embedded view mapping (#11)
Update RoktEmbeddedView references to MPRoktEmbeddedView and remap to RoktEmbeddedView
1 parent 39c73b2 commit 8c29f19

3 files changed

Lines changed: 12 additions & 6 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
# Xcode
55
build/
6+
.build/
67
*.pbxuser
78
!default.pbxuser
89
*.mode1v3

mParticle-Rokt/MPKitRokt.m

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ - (void)start {
8888
///
8989
- (MPKitExecStatus *)executeWithViewName:(NSString * _Nullable)viewName
9090
attributes:(NSDictionary<NSString *, NSString *> * _Nonnull)attributes
91-
placements:(NSDictionary<NSString *, RoktEmbeddedView *> * _Nullable)placements
91+
placements:(NSDictionary<NSString *, MPRoktEmbeddedView *> * _Nullable)placements
9292
callbacks:(MPRoktEventCallback * _Nullable)callbacks
9393
filteredUser:(FilteredMParticleUser * _Nonnull)filteredUser {
9494
NSDictionary<NSString *, NSString *> *mpAttributes = [filteredUser.userAttributes transformValuesToString];
@@ -122,14 +122,19 @@ - (MPKitExecStatus *)executeWithViewName:(NSString * _Nullable)viewName
122122
return [[MPKitExecStatus alloc] initWithSDKCode:[[self class] kitCode] returnCode:MPKitReturnCodeSuccess];
123123
}
124124

125-
- (NSDictionary<NSString *, RoktEmbeddedView *> * _Nullable) confirmPlacements:(NSDictionary<NSString *, RoktEmbeddedView *> * _Nullable)placements {
125+
- (NSDictionary<NSString *, RoktEmbeddedView *> * _Nullable) confirmPlacements:(NSDictionary<NSString *, MPRoktEmbeddedView *> * _Nullable)placements {
126126
NSMutableDictionary <NSString *, RoktEmbeddedView *> *safePlacements = [NSMutableDictionary dictionary];
127127

128128
for (NSString* key in placements) {
129-
id value = [placements objectForKey:key];
129+
MPRoktEmbeddedView *mpView = [placements objectForKey:key];
130130

131-
if ([value isKindOfClass:RoktEmbeddedView.class]) {
132-
[safePlacements setObject:value forKey:key];
131+
if ([mpView isKindOfClass:MPRoktEmbeddedView.class]) {
132+
// Create a new RoktEmbeddedView instance
133+
RoktEmbeddedView *roktView = [[RoktEmbeddedView alloc] initWithFrame:mpView.bounds];
134+
// Add the RoktEmbeddedView as a child view of MPRoktEmbeddedView
135+
[mpView addSubview:roktView];
136+
// Add the RoktEmbeddedView to our safe placements dictionary
137+
[safePlacements setObject:roktView forKey:key];
133138
}
134139
}
135140

mParticle_RoktTests/mParticle_RoktTests.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ @interface MPKitRokt ()
77

88
- (MPKitExecStatus *)executeWithViewName:(NSString * _Nullable)viewName
99
attributes:(NSDictionary<NSString *, NSString *> * _Nonnull)attributes
10-
placements:(NSDictionary<NSString *, RoktEmbeddedView *> * _Nullable)placements
10+
placements:(NSDictionary<NSString *, MPRoktEmbeddedView *> * _Nullable)placements
1111
callbacks:(MPRoktEventCallback * _Nullable)callbacks
1212
filteredUser:(FilteredMParticleUser * _Nonnull)filteredUser;
1313

0 commit comments

Comments
 (0)