Skip to content

Commit ab15ddd

Browse files
fix unit tests
1 parent 2103a7f commit ab15ddd

3 files changed

Lines changed: 5 additions & 13 deletions

File tree

mParticle-Rokt.xcodeproj/project.pbxproj

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,14 @@
88

99
/* Begin PBXBuildFile section */
1010
2502325C2D7A7BF3004794A2 /* Rokt-Widget in Frameworks */ = {isa = PBXBuildFile; productRef = 2502325B2D7A7BF3004794A2 /* Rokt-Widget */; };
11-
7E084C852E0C4B3A0098059B /* MPRoktLayout.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7E084C842E0C4B340098059B /* MPRoktLayout.swift */; };
1211
7E084C862E0C4B3A0098059B /* MPRoktLayout.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7E084C842E0C4B340098059B /* MPRoktLayout.swift */; };
1312
7E15B20B2D9AE82600C1FF3E /* Rokt-Widget in Frameworks */ = {isa = PBXBuildFile; productRef = 7E15B20A2D9AE82600C1FF3E /* Rokt-Widget */; };
1413
7EDDAAB02E05A88E00D089CF /* mParticle-Apple-SDK in Frameworks */ = {isa = PBXBuildFile; productRef = 7EDDAAAF2E05A88E00D089CF /* mParticle-Apple-SDK */; };
1514
7EDDAAB22E05A89B00D089CF /* mParticle-Apple-SDK in Frameworks */ = {isa = PBXBuildFile; productRef = 7EDDAAB12E05A89B00D089CF /* mParticle-Apple-SDK */; };
1615
7EE7F13E2DA95BEE006C5440 /* OCMock in Frameworks */ = {isa = PBXBuildFile; productRef = 7EE7F13D2DA95BEE006C5440 /* OCMock */; };
1716
B34CE55A2E04356F00712DE1 /* MPRoktEventMapper.swift in Sources */ = {isa = PBXBuildFile; fileRef = B3D778512E02845700D887A4 /* MPRoktEventMapper.swift */; };
18-
B3D778532E02845700D887A4 /* MPRoktEventMapper.swift in Sources */ = {isa = PBXBuildFile; fileRef = B3D778512E02845700D887A4 /* MPRoktEventMapper.swift */; };
1917
DBB01A601DC1478A00A7B188 /* mParticle_Rokt.h in Headers */ = {isa = PBXBuildFile; fileRef = DBB01A5E1DC1478A00A7B188 /* mParticle_Rokt.h */; settings = {ATTRIBUTES = (Public, ); }; };
20-
DBB01A681DC1480700A7B188 /* MPKitRokt.h in Headers */ = {isa = PBXBuildFile; fileRef = DBB01A661DC1480700A7B188 /* MPKitRokt.h */; };
18+
DBB01A681DC1480700A7B188 /* MPKitRokt.h in Headers */ = {isa = PBXBuildFile; fileRef = DBB01A661DC1480700A7B188 /* MPKitRokt.h */; settings = {ATTRIBUTES = (Public, ); }; };
2119
DBB01A691DC1480700A7B188 /* MPKitRokt.m in Sources */ = {isa = PBXBuildFile; fileRef = DBB01A671DC1480700A7B188 /* MPKitRokt.m */; };
2220
FF0BB63E217A84E800B0556C /* mParticle_RoktTests.m in Sources */ = {isa = PBXBuildFile; fileRef = FF0BB63D217A84E800B0556C /* mParticle_RoktTests.m */; };
2321
FF0BB640217A84E800B0556C /* mParticle_Rokt.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = DBB01A5B1DC1478A00A7B188 /* mParticle_Rokt.framework */; };
@@ -250,8 +248,6 @@
250248
isa = PBXSourcesBuildPhase;
251249
buildActionMask = 2147483647;
252250
files = (
253-
B3D778532E02845700D887A4 /* MPRoktEventMapper.swift in Sources */,
254-
7E084C852E0C4B3A0098059B /* MPRoktLayout.swift in Sources */,
255251
FF0BB63E217A84E800B0556C /* mParticle_RoktTests.m in Sources */,
256252
);
257253
runOnlyForDeploymentPostprocessing = 0;

mParticle-Rokt/MPRoktLayout.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public struct MPRoktLayout: View {
3030
onShouldShowLoadingIndicator: (() -> Void)? = nil,
3131
onShouldHideLoadingIndicator: (() -> Void)? = nil
3232
) {
33-
MPKitRokt.prepareAttributes(attributes, filteredUser: nil, performMapping: true)
33+
MPKitRokt.prepareAttributes(attributes, filteredUser: Optional<FilteredMParticleUser>.none, performMapping: true)
3434

3535
self.roktLayout = RoktLayout.init(
3636
sdkTriggered: sdkTriggered,

mParticle_RoktTests/mParticle_RoktTests.m

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ - (MPKitExecStatus *)purchaseFinalized:(NSString *)placementId
2121

2222
- (NSDictionary<NSString *, RoktEmbeddedView *> * _Nullable) confirmEmbeddedViews:(NSDictionary<NSString *, MPRoktEmbeddedView *> * _Nullable)embeddedViews;
2323

24-
- (NSDictionary<NSString *, NSString *> *) filteredUserAttributes:(NSDictionary<NSString *, NSString *> * _Nonnull)attributes kitConfiguration:(MPKitConfiguration *)kitConfiguration;
25-
26-
- (void)addIdentityAttributes:(NSMutableDictionary<NSString *, NSString *> * _Nullable)attributes filteredUser:(FilteredMParticleUser * _Nonnull)filteredUser;
24+
+ (void)addIdentityAttributes:(NSMutableDictionary<NSString *, NSString *> * _Nullable)attributes filteredUser:(FilteredMParticleUser * _Nonnull)filteredUser;
2725

2826
+ (RoktConfig *)convertMPRoktConfig:(MPRoktConfig *)mpRoktConfig;
2927

@@ -196,8 +194,7 @@ - (void)testAddIdentityAttributes {
196194
id mockfilteredUser = OCMPartialMock(filteredUser);
197195
[[[mockfilteredUser stub] andReturn:testIdentities] userIdentities];
198196

199-
MPKitRokt *kit = [[MPKitRokt alloc] init];
200-
[kit addIdentityAttributes:passedAttributes filteredUser:filteredUser];
197+
[MPKitRokt addIdentityAttributes:passedAttributes filteredUser:filteredUser];
201198

202199
XCTAssertEqualObjects(passedAttributes[@"customerid"], @"testCustomerID");
203200
XCTAssertEqualObjects(passedAttributes[@"email"], @"testEmail@gmail.com");
@@ -259,8 +256,7 @@ - (void)testAddIdentityAttributesWithExistingAttributes {
259256
id mockfilteredUser = OCMPartialMock(filteredUser);
260257
[[[mockfilteredUser stub] andReturn:testIdentities] userIdentities];
261258

262-
MPKitRokt *kit = [[MPKitRokt alloc] init];
263-
[kit addIdentityAttributes:passedAttributes filteredUser:filteredUser];
259+
[MPKitRokt addIdentityAttributes:passedAttributes filteredUser:filteredUser];
264260

265261
XCTAssertEqualObjects(passedAttributes[@"foo"], @"bar");
266262
XCTAssertEqualObjects(passedAttributes[@"customerid"], @"testCustomerID");

0 commit comments

Comments
 (0)