feat: Update Hashed Email for Rokt

Author: BrandonStalnaker

mParticle-Rokt/MPKitRokt.m

@@ -334,22 +334,11 @@ + (void)addIdentityAttributes:(NSMutableDictionary<NSString *, NSString *> * _Nu
 
 + (void)handleHashedEmail:(NSMutableDictionary<NSString *, NSString *> * _Nullable)attributes {
     NSString *emailKey = [MPKitRokt stringForIdentityType:MPIdentityEmail];
-    NSString *otherKey = [MPKitRokt stringForIdentityType:MPIdentityOther];
     NSString *hashedEmailValue = attributes[@"emailsha256"];
 
-    // Remove email and other is hashed vlaue already set
+    // Remove email if hashed value set
     if (hashedEmailValue != nil) {
         [attributes removeObjectForKey:emailKey];
-        [attributes removeObjectForKey:otherKey];
-    }
-    
-    NSString *otherValue = attributes[otherKey];
-    
-    // Remove email and replace key on other if it's set
-    if (otherValue != nil) {
-        [attributes removeObjectForKey:emailKey];
-        attributes[@"emailsha256"] = otherValue;
-        [attributes removeObjectForKey:otherKey];
     }
 }
 
@@ -393,7 +382,7 @@ + (NSString *)stringForIdentityType:(MPIdentity)identityType {
             return @"microsoft";
 
         case MPIdentityOther:
-            return @"other";
+            return @"emailsha256";
 
         case MPIdentityTwitter:
             return @"twitter";

mParticle_RoktTests/mParticle_RoktTests.m

@@ -244,7 +244,8 @@ - (void)testAddIdentityAttributes {
     XCTAssertEqualObjects(passedAttributes[@"facebookcustomaudienceid"], @"testCustomAudienceID");
     XCTAssertEqualObjects(passedAttributes[@"google"], @"testGoogle");
     XCTAssertEqualObjects(passedAttributes[@"microsoft"], @"testMicrosoft");
-    XCTAssertEqualObjects(passedAttributes[@"other"], @"testOther");
+    XCTAssertNil(passedAttributes[@"other"]);
+    XCTAssertEqualObjects(passedAttributes[@"emailsha256"], @"testOther");
     XCTAssertEqualObjects(passedAttributes[@"twitter"], @"testTwitter");
     XCTAssertEqualObjects(passedAttributes[@"yahoo"], @"testYahoo");
     XCTAssertEqualObjects(passedAttributes[@"other2"], @"testOther2");
@@ -307,7 +308,8 @@ - (void)testAddIdentityAttributesWithExistingAttributes {
     XCTAssertEqualObjects(passedAttributes[@"facebookcustomaudienceid"], @"testCustomAudienceID");
     XCTAssertEqualObjects(passedAttributes[@"google"], @"testGoogle");
     XCTAssertEqualObjects(passedAttributes[@"microsoft"], @"testMicrosoft");
-    XCTAssertEqualObjects(passedAttributes[@"other"], @"testOther");
+    XCTAssertNil(passedAttributes[@"other"]);
+    XCTAssertEqualObjects(passedAttributes[@"emailsha256"], @"testOther");
     XCTAssertEqualObjects(passedAttributes[@"twitter"], @"testTwitter");
     XCTAssertEqualObjects(passedAttributes[@"yahoo"], @"testYahoo");
     XCTAssertEqualObjects(passedAttributes[@"other2"], @"testOther2");
@@ -504,10 +506,10 @@ - (void)testHandleHashedEmailOtherOverride {
 
     [MPKitRokt handleHashedEmail:passedAttributes];
 
-    XCTAssertNil(passedAttributes[@"email"]);
-    XCTAssertNil(passedAttributes[@"other"]);
-    XCTAssertEqualObjects(passedAttributes[@"emailsha256"], @"test@gmail.com");
-    XCTAssertTrue(passedAttributes.allKeys.count == 1);
+    XCTAssertEqualObjects(passedAttributes[@"email"], @"foo@gmail.com");
+    XCTAssertEqualObjects(passedAttributes[@"other"], @"test@gmail.com");
+    XCTAssertNil(passedAttributes[@"emailsha256"]);
+    XCTAssertTrue(passedAttributes.allKeys.count == 2);
 }
 
 - (void)testHandleHashedEmailHashedOverride {
@@ -519,9 +521,9 @@ - (void)testHandleHashedEmailHashedOverride {
     [MPKitRokt handleHashedEmail:passedAttributes];
 
     XCTAssertNil(passedAttributes[@"email"]);
-    XCTAssertNil(passedAttributes[@"other"]);
+    XCTAssertEqualObjects(passedAttributes[@"other"], @"test@gmail.com");
     XCTAssertEqualObjects(passedAttributes[@"emailsha256"], @"test2@gmail.com");
-    XCTAssertTrue(passedAttributes.allKeys.count == 1);
+    XCTAssertTrue(passedAttributes.allKeys.count == 2);
 }
 
 - (void)testTransformValuesToString {