Skip to content

refactor: Rename parameters for clarity in MPKitRokt methods#15

Merged
BrandonStalnaker merged 1 commit into
mainfrom
refactor/SQDSDKS-7419-rename-execute-kit-interface
Jun 17, 2025
Merged

refactor: Rename parameters for clarity in MPKitRokt methods#15
BrandonStalnaker merged 1 commit into
mainfrom
refactor/SQDSDKS-7419-rename-execute-kit-interface

Conversation

@thomson-t

@thomson-t thomson-t commented Jun 17, 2025

Copy link
Copy Markdown
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Updated method signatures and documentation to replace 'viewName' with 'identifier' and 'placements' with 'embeddedViews'

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@thomson-t thomson-t changed the base branch from main to develop June 17, 2025 06:31
@thomson-t thomson-t changed the base branch from develop to main June 17, 2025 06:31
@thomson-t thomson-t force-pushed the refactor/SQDSDKS-7419-rename-execute-kit-interface branch 2 times, most recently from 2e6ecf2 to 66a78d6 Compare June 17, 2025 06:36
Updated method signatures and documentation to replace 'viewName' with 'identifier' and 'placements' with 'embeddedViews'
@thomson-t thomson-t force-pushed the refactor/SQDSDKS-7419-rename-execute-kit-interface branch from 66a78d6 to 32191d6 Compare June 17, 2025 06:42

@BrandonStalnaker BrandonStalnaker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker

Copy link
Copy Markdown
Collaborator

corresponding core PR mParticle/mparticle-apple-sdk#368

@BrandonStalnaker BrandonStalnaker merged commit 88b324d into main Jun 17, 2025
3 of 4 checks passed
@BrandonStalnaker BrandonStalnaker deleted the refactor/SQDSDKS-7419-rename-execute-kit-interface branch June 17, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants